Repository navigation
chore: restore regression coverage after WebUI retirement #11101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2a11002
chore(web-shell): follow up #9812 review findings and deferred sugges…
yiliang114 541b83a
fix(test): poll the theme class instead of a matcher vitest lacks
yiliang114 0d9e2ad
fix(test): assert the exported theme class exactly
yiliang114 735bfb9
fix(test): realpath the exporter main check and pin its JSONL guard
yiliang114 88ba846
Merge origin/main into fix/follow-up-9812-review-suggestions
yiliang114 97594ad
docs(followup): name the real ACP stop reasons, drop "unconditional"
yiliang114 d20151e
test(web-shell): drop the duplicate historical-key assertion
yiliang114 4112713
test(integration): drop the unreachable unhandledrejection arm
yiliang114 503a5b4
ci(review-context): route concurrent-runner changes to the helper-tes…
yiliang114 c5a45ce
Merge origin/main into fix/follow-up-9812-review-suggestions
yiliang114 a3ddb06
Merge branch 'main' into fix/follow-up-9812-review-suggestions
yiliang114 966d948
Merge remote-tracking branch 'origin/main' into HEAD
yiliang114 95a35e0
fix(deps): sync pnpm lockfile for Playwright pin
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
integration-tests/concurrent-runner/export-html-from-chatrecord-jsonl.test.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Qwen Team | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import assert from 'node:assert/strict'; | ||
| import test from 'node:test'; | ||
|
|
||
| import { | ||
| looksLikeChatRecord, | ||
| looksLikeExportJsonl, | ||
| } from './export-html-from-chatrecord-jsonl.js'; | ||
|
yiliang114 marked this conversation as resolved.
Resolved
|
||
|
|
||
| function chatRecord(overrides = {}) { | ||
|
yiliang114 marked this conversation as resolved.
Resolved
|
||
| return { | ||
| uuid: 'uuid-1', | ||
| parentUuid: null, | ||
| sessionId: 'session-1', | ||
| timestamp: '2026-09-05T00:00:00.000Z', | ||
| type: 'user', | ||
| cwd: '/workspace', | ||
| version: '1', | ||
| ...overrides, | ||
| }; | ||
| } | ||
|
|
||
| test('rejects legacy exported JSONL (session_metadata-first envelope)', () => { | ||
| const legacy = [ | ||
| { | ||
| type: 'session_metadata', | ||
| sessionId: 'session-1', | ||
| startTime: '2026-09-05T00:00:00.000Z', | ||
| }, | ||
| ]; | ||
|
|
||
| assert.equal(looksLikeExportJsonl(legacy), true); | ||
| // A legacy envelope is not a ChatRecord, so it can never take the happy path. | ||
| assert.equal(looksLikeChatRecord(legacy[0]), false); | ||
|
yiliang114 marked this conversation as resolved.
Resolved
|
||
| }); | ||
|
|
||
| test('accepts source ChatRecord JSONL', () => { | ||
| const records = [chatRecord()]; | ||
|
|
||
| assert.equal(looksLikeExportJsonl(records), false); | ||
| assert.equal(looksLikeChatRecord(records[0]), true); | ||
| }); | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.