Repository navigation
fix(core): harden Config.initialize() join path #11075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 82d82c7 — the reorder is exactly as suggested:
release()stays, soawait expect(first).resolves.toBeUndefined()still holds.On the requested mutation witness: I did not run the mutant probe, so I am not claiming a reproduced red. The argument the reorder rests on is structural —
options?.signal?.throwIfAborted()sits ahead of everyawaitininitialize()(config.ts:3013, beforeawait this.initializationPromise), so the joining promise settles on the first microtask and the pre-release()assertion resolves without the first flight finishing. Move the guard below thatawaitand the assertion has nothing to settle it while the gate is held, which is the 60s timeout your matrix recorded. CI on this head is the check that the shipped ordering is green.The comment above the assertions now says why the order matters, so the next reader does not "tidy" it back.
中文说明
已在 82d82c7 中按建议重排,
release()保留,原有的await expect(first).resolves.toBeUndefined()仍然成立。关于要求的变异见证:我没有跑变异体探针,因此不声称复现了红。重排所依赖的是结构性理由——
options?.signal?.throwIfAborted()位于initialize()中所有await之前(config.ts:3013,在await this.initializationPromise之前),所以加入方的 promise 在第一个 microtask 就落定,release()之前的断言无需等第一次初始化结束即可完成。把守卫移到该await之后,门控仍被持有时该断言就没有任何东西能让它落定,正是你矩阵里记录的 60 秒超时。当前 head 的 CI 负责验证重排后的测试是绿的。断言上方的注释已写明顺序为什么重要,避免后来者把它「整理」回去。