Repository navigation
perf(cli): import core modules directly in another 114 files #10956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,8 @@ | |
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { Storage, type Config } from '@qwen-code/qwen-code-core'; | ||
| import type { Config } from '@qwen-code/qwen-code-core/config/config.js'; | ||
| import { Storage } from '@qwen-code/qwen-code-core/config/storage.js'; | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified real at head 2e7b7eb: ran the seven suites together (acpAgent, curator-command, workspace-git-diff, workspace-git-log, workspace-github-prs, local-control/service, McpPromptLoader) — 7 files failed, 70 tests failed, matching the reported signatures (spies record 0 calls, real implementations reach fs/git, 200 vs expected 502). This PR changes no test files, so the source import rewrites are the cause. Not auto-fixing because both remedies exceed three files: (a) revert these seven source files to barrel imports and let the mock-migration change convert them (the series' own selection rule), or (b) move vi.mock in all seven test files to the exact subpath modules, reusing the same Storage fake in acpAgent.test.ts. @yiliang114 which direction? Leaving open until decided. |
||
| import { RequestError } from '@agentclientprotocol/sdk'; | ||
| import * as fs from 'node:fs/promises'; | ||
| import * as path from 'node:path'; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.