chore(vscode): refresh NOTICES for the fast-uri bump - #10863
Conversation
The lockfile bump moved fast-uri and the companion's notices carry a version on each dependency's header line, so the generated file went stale and its up-to-date check failed the build — the same shape #10842 hit when its own lockfile bump landed without this. Derived rather than regenerated: the bump touched only fast-uri, its old version appears once in the file, and the same derivation on #10842 came out byte-identical to the regenerated file committed there. Claude-Session: https://claude.ai/code/session_01AWWgJEqafyAT1Mc75T8N7h
|
⏳ Approval still deferred — 2 PR CI workflow run(s) still in progress for ⏳ 审批仍在延迟中 —— |
|
Thanks for the quick follow-up! Template looks good ✓ Problem: real and deterministic. #10862 landed the lockfile bump (fast-uri 3.1.5 → 3.1.7) without regenerating the companion notices, and the "Check VS Code companion notices are up-to-date" step regenerates the file and fails on any diff. On main, Direction: aligned — this restores a required green gate on main and unblocks every other PR's merge-ref CI. No CHANGELOG surface (generated metadata), which is expected. Size: not a core path. One generated metadata file, +1/−1. Approach: exactly right — one header line, which is precisely what Risk: no elevated risk signals. Moving on to code review. 🔍 中文说明感谢快速跟进! 模板完整 ✓ 问题:真实存在且是确定性的。#10862 合入了 lockfile 升级(fast-uri 3.1.5 → 3.1.7)但没有重新生成 companion notices,而 "Check VS Code companion notices are up-to-date" 步骤会重新生成该文件并在有 diff 时失败。main 上 方向:对齐——这恢复了 main 上必须为绿的门禁,并解锁其他所有 PR 的 merge-ref CI。CHANGELOG 无体现(生成的元数据),这是预期内的。 规模:非核心路径。一个生成的元数据文件,+1/−1。 方案:恰好——一行头部文本,正是 风险:无升级风险信号。 进入代码审查 🔍 — Qwen Code · qwen3.8-max Reviewed at |
Code reviewIndependent pass first: the right fix here is to regenerate the companion notices ( The one line is byte-complete: upstream fast-uri changed no license or notice files between v3.1.5 and v3.1.7 (only Testing evidenceUnattended CI run — no PR code was executed; the evidence below is the PR's own CI on the reviewed commit, read through the API, plus the observed failure that motivated this PR. Observed failure (the problem this fixes): #10862's own CI already showed the breakage — its This PR's CI: the decisive signal is the same step inside CI results for
One row per check name (latest run); skipped checks omitted; failures sort first. / 每个检查名一行(取最新一次运行),省略 skipped,失败项排在最前。 The macOS/Windows lane skips are expected for a notices-only change; those jobs don't carry the notices check anyway. Not verified: nothing beyond the pending CI above — this is a generated metadata file with no runtime behavior, so there is no behavioral claim for a sandboxed 中文说明代码审查:先做独立方案——正确的修复就是重新生成 companion notices( 测试证据:无人值守 CI 运行——未执行任何 PR 代码;证据来自对被审提交自身 CI 的 API 读取,外加触发本修复的已观测失败。已观测失败:#10862 自身的 CI 已展示了这一损坏——其 — Qwen Code · qwen3.8-max Reviewed at |
|
Confidence: 5/5 — one generated line that restores a broken gate, verified byte-complete from three independent directions. Stepping back: my independent proposal was "run the generator, commit what comes out" — and this PR is exactly that output. The only way it could be wrong is if regeneration produced more than one line, and that is excluded three ways: upstream fast-uri changed no license or notice files between the two versions, #10862's lockfile diff moved exactly one resolved URL, and #10862's own failing CI run recorded the regeneration delta as This is the minimal payment on a debt #10862's merge left behind, and every other PR's merge-ref CI stays red at the notices step until it lands. Approval is deferred until CI lands green on 中文说明回顾:我的独立方案是"跑生成器、提交产物"——本 PR 正是该产物。唯一可能的错误是重新生成产生多于一行,而这被三个方向排除:fast-uri 上游两个版本间未改动任何 license/notice 文件;#10862 的 lockfile diff 只动了一个 resolved URL;#10862 自身失败的 CI 运行记录的重生成差异恰为 — Qwen Code · qwen3.8-max Reviewed at |
qwen-code-dev-bot
left a comment
There was a problem hiding this comment.
Reviewed at head 0a54b876. A single notices line: fast-uri@3.1.5 → 3.1.7, matching the version the root lockfile actually resolves for node_modules/fast-uri at this head — the copyright/license block itself is unchanged between those releases, so the notice body stays valid. Pure metadata re-alignment, nothing to review beyond the version claim, which checks out. CI has no failures on this head (lanes still running); per the channel convention the call is on the review itself.
|
Post-merge review (PR merged 2026-09-03T02:09:59Z) No blocking findings. Tier: Scan — single-line update to a generated NOTICES file. Checked
Not covered: No executable code changed — runtime rungs not applicable. Cross-check: Reviewed with AI assistance. |
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
|
Released in v0.23.0. |
What this PR does
Updates the VS Code companion's
NOTICES.txtheader line forfast-urifrom3.1.5to3.1.7, matching the lockfile bump that #10862 landed on main.Why it's needed
The companion's notices carry a version on each dependency's header line, and CI regenerates the file and diffs it ("Check VS Code companion notices are up-to-date"). After the lockfile bump landed without this file, that check is red on main and fails every PR merge-ref run until fixed.
Reviewer Test Plan
How to verify
The change is one line produced by the same derivation #10842 used, which came out byte-identical to a full regeneration of the file. CI's notices check going green on this PR is the end-to-end confirmation.
Evidence (Before & After)
N/A — generated metadata file, no user-visible output.
Tested on
Verified by the CI notices check on this PR (Linux lane).
Environment (optional)
N/A (metadata file).
Risk & Scope
Linked Issues
Follow-up to #10862 (the lockfile bump landed without the companion notices).
中文说明
本 PR 把 VS Code companion 的
NOTICES.txt中fast-uri的头部版本行从3.1.5更新为3.1.7,与 #10862 合入 main 的 lockfile 升级保持一致。原因:companion 的 notices 在每个依赖的头部行携带版本号,CI 会重新生成该文件并 diff。lockfile 升级合入时未带上此文件,导致 main 上该检查变红,并在修复前拖红所有 PR 的 merge-ref 检查。
验证:单行改动采用与 #10842 相同的推导方式(该推导与完整重新生成的结果逐字节一致),以本 PR 的 CI notices 检查变绿作为端到端确认。无用户可见变化。风险与范围:无——仅一行生成的头部文本;无破坏性变更。关联:#10862 的后续修复。