fix(autofix): clamp gate test load explicitly instead of via RUNNER_NAME #10671
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,9 @@ | |
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { readFileSync } from 'node:fs'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import externalContextConfig from '../../integrations/external-context/vitest.config.js'; | ||
| import externalContextMem0Config from '../../integrations/external-context-mem0/vitest.config.js'; | ||
|
|
@@ -38,7 +40,11 @@ import scriptsTestsConfig from './vitest.config.js'; | |
| // witness pins the flag in every guarded config so removing it from any | ||
| // one of them fails the scripts suite on every platform. | ||
| type ExemptionConfig = { | ||
| test?: { | ||
| dangerouslyIgnoreUnhandledErrors?: boolean; | ||
| pool?: 'threads' | 'forks' | 'vmThreads'; | ||
| poolOptions?: { threads?: { maxThreads?: number } }; | ||
| }; | ||
| }; | ||
|
|
||
| const configs: Record<string, ExemptionConfig> = { | ||
|
|
@@ -85,3 +91,106 @@ describe('unhandled-error exemption on the platform lanes', () => { | |
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('autofix gate load clamps', () => { | ||
| // The gate launches vitest through an `env -i` allowlist that drops | ||
| // RUNNER_NAME, so these configs' ECS branches deactivate in there and the | ||
| // gate passes the same numbers on the command line instead — where they | ||
| // outrank the config. That makes the shell array the effective ceiling | ||
| // for every gate round, so it has to track the configs: raising an ECS | ||
| // ceiling here to shelter a heavier test would otherwise leave the gate | ||
| // enforcing the old one and rejecting a fix that is green in normal CI. | ||
| it('carries the same values as the ECS branch of the configs they stand in for', async () => { | ||
| vi.stubEnv('RUNNER_NAME', 'ecs-qwen-parity'); | ||
| vi.resetModules(); | ||
| // Re-imported under the stub: the configs read the env at import time, | ||
| // and the static imports above already resolved the non-ECS branch. | ||
| const [core, cli, acpBridge] = await Promise.all([ | ||
| import('../../packages/core/vitest.config.js'), | ||
| import('../../packages/cli/vitest.config.js'), | ||
| import('../../packages/acp-bridge/vitest.config.js'), | ||
| ]); | ||
| vi.unstubAllEnvs(); | ||
|
|
||
| const script = readFileSync( | ||
| fileURLToPath( | ||
| new URL( | ||
| '../../.github/scripts/run-autofix-review-verification.sh', | ||
| import.meta.url, | ||
| ), | ||
| ), | ||
| 'utf8', | ||
| ); | ||
| const body = script.match(/^VITEST_LOAD_CLAMPS=\(\n([\s\S]*?)\n\)$/m)?.[1]; | ||
| expect( | ||
| body, | ||
| 'VITEST_LOAD_CLAMPS not found in the gate script', | ||
| ).toBeTruthy(); | ||
| const clamps = Object.fromEntries( | ||
| body! | ||
| .split('\n') | ||
| .map((line) => line.trim().replace(/^--/, '')) | ||
| .filter(Boolean) | ||
| .map((flag) => flag.split('=') as [string, string]), | ||
| ); | ||
|
|
||
| // 60_000 / 60_000 / '25%' on the ECS branch of core and cli; | ||
| // acp-bridge sets the two timeouts but defines no maxWorkers. | ||
| for (const config of [core.default, cli.default, acpBridge.default]) { | ||
| expect(String(config.test?.testTimeout)).toBe(clamps['testTimeout']); | ||
| expect(String(config.test?.hookTimeout)).toBe(clamps['hookTimeout']); | ||
| } | ||
| for (const config of [core.default, cli.default]) { | ||
| expect(config.test?.maxWorkers).toBe(clamps['maxWorkers']); | ||
| } | ||
| // Nothing in the gate or its report path consumes coverage, and | ||
| // collecting it was the bulk of the 60-minute overruns. | ||
| expect(clamps['coverage.enabled']).toBe('false'); | ||
| }); | ||
|
|
||
| it('pins the numeric thread cap that shields vitest-1.x legs from --maxWorkers', () => { | ||
| // The clamps pass --maxWorkers=25% to every vitest the gate launches. | ||
| // vitest 1.x coerces that value with Number('25%') -> NaN, and its | ||
| // tinypool then builds new Array(NaN): RangeError, zero tests | ||
| // collected, exit 1. The pool builder reads a numeric | ||
| // poolOptions.threads.maxThreads before ctx.config.maxWorkers, so | ||
| // that cap is the shield keeping a 1.x workspace's legs alive under | ||
| // the clamps — pin it here so removing it fails the suite instead of | ||
| // crashing every gate leg for the workspace. | ||
| const lock = JSON.parse( | ||
| readFileSync( | ||
| fileURLToPath(new URL('../../package-lock.json', import.meta.url)), | ||
| 'utf8', | ||
| ), | ||
| ) as { packages: Record<string, { version?: string }> }; | ||
| const hoisted = lock.packages['node_modules/vitest']?.version ?? ''; | ||
| // Nested lockfile copies under workspace dirs are exactly the | ||
| // workspaces whose pinned vitest differs from the hoisted one; if the | ||
| // hoisted copy itself were 1.x this filter would go blind, so pin the | ||
| // premise. | ||
| expect(Number(hoisted.split('.')[0])).toBeGreaterThanOrEqual(2); | ||
| const legacyWorkspaces = Object.entries(lock.packages) | ||
| .filter( | ||
| ([path, entry]) => | ||
| path.endsWith('/node_modules/vitest') && | ||
| (path.startsWith('packages/') || path.startsWith('integrations/')) && | ||
| Number(entry.version?.split('.')[0] ?? 99) < 2, | ||
| ) | ||
| .map(([path]) => path.slice(0, -'/node_modules/vitest'.length)); | ||
| for (const workspace of legacyWorkspaces) { | ||
| if (!(workspace in configs)) { | ||
| throw new Error( | ||
| `${workspace} pins vitest 1.x; add its config to the registry above so the shield is pinned`, | ||
| ); | ||
| } | ||
| const config = configs[workspace]; | ||
| // forks reads poolOptions.forks, which these configs do not set — | ||
| // only the threads pool carries the shield. | ||
| expect(config.test?.pool ?? 'threads', workspace).toBe('threads'); | ||
| expect( | ||
| typeof config.test?.poolOptions?.threads?.maxThreads, | ||
| workspace, | ||
| ).toBe('number'); | ||
| } | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.