Repository navigation
fix(ci): keep contended ECS E2E shards above the flat 60-minute ceiling (#10591) #10597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
64a703c
f2b2a2f
77eb9c1
6e0848e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,8 +46,12 @@ jobs: | |
| # Kill-switch: MAINTAINER_ECS_RUNNER_DISABLED. | ||
| runs-on: '${{ (github.repository == ''QwenLM/qwen-code'' && vars.MAINTAINER_ECS_RUNNER_DISABLED != ''true'') && fromJSON(''["self-hosted", "linux", "x64", "ecs-qwen"]'') || fromJSON(''["ubuntu-latest"]'') }}' | ||
| # A wedged shard must free the pool runner well before GitHub's | ||
| # 360-minute default; 60 matches ci.yml's pool jobs. | ||
| timeout-minutes: 60 | ||
| # 360-minute default. The ceiling is extended on the ECS pool only, | ||
| # mirroring ci.yml's pool lanes: run 33345905817 (issue #10591) expired | ||
| # at the old flat 60 on a contended shared host before its log reported | ||
| # any test result. Hosted fallbacks keep the pre-contention ceiling so | ||
| # a genuine hang there does not burn the extra 30 minutes. | ||
| timeout-minutes: "${{ fromJSON((github.repository == 'QwenLM/qwen-code' && vars.MAINTAINER_ECS_RUNNER_DISABLED != 'true') && '90' || '60') }}" | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified real at the current head: This round nevertheless does NOT implement the pin update:
Leaving this thread open until a maintainer chooses. 中文说明已在当前 head 上确认为真实问题: 但本轮不实施该断言更新:
在维护者作出选择之前,本线程保持打开。
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified real at the current head: This round nevertheless does NOT implement the pin update:
Leaving this thread open until a maintainer chooses. 中文说明已在当前 head 上确认为真实问题: 但本轮不实施该断言更新:
在维护者作出选择之前,本线程保持打开。 |
||
| # Skip on fork PRs: forks have no access to repository secrets | ||
| # (OPENAI_*, DOCKERHUB_*), so the matrix would fail unconditionally | ||
| # and show misleading red status. Same-repo PRs run normally. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified real at the current head:
node --test --test-concurrency=1 .github/scripts/ci-runner-routing.test.mjsfails at line 552 (strictEqualexpected60, actual is the new routing-scoped expression string) — 23 tests, 22 pass, 1 fail. The fullHELPER_TESTSset confirms this is the sole cause of the red requiredTest (ubuntu-latest, Node 22.x)check: 500 tests, exactly this one failure.This round nevertheless does NOT implement the pin update:
.github/scripts/is outside this PR's footprint (the PR touches only.github/workflows/e2e.ymlandscripts/tests/e2e-workflow.test.js), and the round-3 attempt at exactly this pin update was rejected by the autofix gate and reverted for that reason. Repeating the rejected change would fail the gate again, and there is no in-footprint change that can turn the check green while the pin still reads60. This needs a maintainer decision on where the pin update lands:.github/scripts/, so a next round updates the pin here (substitute-then-evaluate: 90 on the pool routing, 60 on both hosted fallbacks, mirroring theruns-oncondition; plus the stale "Pin the ci.yml pool precedent" comment); orLeaving this thread open until a maintainer chooses.
中文说明
已在当前 head 上确认为真实问题:
node --test --test-concurrency=1 .github/scripts/ci-runner-routing.test.mjs在第 552 行失败(strictEqual期望60,实际为新的路由限定表达式字符串)——23 个测试,22 通过,1 失败。完整HELPER_TESTS集合确认这是必需的Test (ubuntu-latest, Node 22.x)检查变红的唯一原因:共 500 个测试,仅此一处失败。但本轮不实施该断言更新:
.github/scripts/在本 PR 的 footprint 之外(本 PR 只改动.github/workflows/e2e.yml和scripts/tests/e2e-workflow.test.js),且第 3 轮对同一断言的更新尝试已被 autofix gate 以该理由拒绝并回滚。重复被拒绝的改动只会再次被 gate 拒绝,而在断言仍钉死60的情况下,footprint 内没有任何改动能让该检查变绿。需要维护者决定断言更新落在哪里:.github/scripts/,下一轮即可在此更新断言(先替换再求值:资源池路由 90、两种托管回退均为 60,与runs-on条件保持一致;同时修正过时的 "Pin the ci.yml pool precedent" 注释);或在维护者作出选择之前,本线程保持打开。