ci: apply shared-runner integration limits to release - #10592
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
Thanks for the PR!
Moving on to code review. 🔍 中文说明感谢贡献!
进入代码审查 🔍 — Qwen Code · qwen3.8-max Reviewed at |
Code reviewIndependent baseline first: given "the release lane misses #10567's fork cap because
Testing evidenceThis is an unattended CI run, so the evidence below is the PR's own CI check results fetched once through the API (PR code was not built or executed here).
No red checks at fetch time; the two lanes that actually exercise this diff (the unit/scripts suite and the no-AK integration gate) were still running, so the table above will be updated in place by the finalize job once CI settles. One thing pre-merge CI structurally cannot show: whether the contention relief actually holds in real release runs — that only becomes observable in post-merge nightly runs on the shared ECS pool, and no sandboxed lane ( 中文说明代码审查:先写独立方案再对照——针对"release lane 缺少 #10567 的单 fork 限制,因为从未导出
测试证据:本次为无人值守 CI 运行,以上证据为通过 API 一次性获取的 PR 自身 CI 检查结果(此处未构建或执行 PR 代码)。获取时无红色检查;真正覆盖本 diff 的两条 lane(ubuntu 单测/脚本套件、no-AK 集成门禁)仍在运行,表格将由 finalize 任务在 CI 结束后就地更新。预合入 CI 在结构上无法展示的一点:竞争缓解是否在真实 release run 中生效——只能在合入后的 nightly run(共享 ECS 池)中观察,任何沙箱 lane( — Qwen Code · qwen3.8-max Reviewed at |
|
Confidence: 5/5 — clean across every stage; a two-line wiring fix that exactly matches the independently-derived approach and pins itself with a regression test. This is the remainder of #10567 that never got wired up: the release lane runs on the same shared ECS pool but never exported 中文说明Confidence: 5/5 —— 各阶段全部干净;一个两行接线修复,与独立推导出的方案完全一致,并用回归测试把自己固定住。 这就是 #10567 一直没接上的剩余部分:release lane 跑在同一个共享 ECS 池上,却从未导出 — Qwen Code · qwen3.8-max Reviewed at |
|
Released in v0.23.0. |
What this PR does
This change passes the actual GitHub runner environment into both Release integration jobs, so the shared self-hosted ECS path uses the single-fork integration-test limit introduced by #10567 while the hosted fallback keeps the existing two-to-four-fork range. A workflow regression test pins the mapping for both the no-sandbox and Docker jobs.
Why it's needed
Release run 33282281913 failed when two
qwen serveintegration tests repeatedly exceeded the existing 10-second ACP initialization budget under shared-host contention. The Release jobs run on the same ECS pool addressed by #10567, but they did not exportRUNNER_ENVIRONMENT; as a result, the integration-test configuration still selected two-to-four Vitest forks there and the new contention limit never applied to Release. This closes that wiring gap without changing the production timeout or weakening the tests.Reviewer Test Plan
How to verify
Confirm that both Release integration jobs expose the real runner environment to the integration-test process. On a self-hosted runner, the configuration should resolve to one Vitest fork; on the hosted fallback, it should remain at two-to-four forks. The focused workflow and integration configuration suites should stay green.
Local verification: ESLint passed for the changed test; the two focused suites passed 32 tests with one platform-conditional skip; Prettier and
git diff --checkpassed.Evidence (Before & After)
N/A — CI workflow configuration only.
Tested on
Environment (optional)
Local focused workflow-contract and Vitest-configuration tests using the repository's pinned toolchain.
Risk & Scope
Linked Issues
Fixes #10535
Related: #10567
中文说明
本 PR 做了什么
将实际的 GitHub runner 环境传给 Release 的两个集成测试 job,使共享自托管 ECS 路径能够使用 #10567 引入的单 fork 限制,而托管 fallback 继续保持原有的 2–4 个 fork。新增 workflow 回归测试,固定无沙箱和 Docker 两个 job 的变量接线。
为什么需要
Release run 33282281913 中,两个
qwen serve集成测试在共享主机资源竞争下反复超过现有的 10 秒 ACP 初始化预算。Release job 使用的正是 #10567 针对的 ECS 池,但此前没有导出RUNNER_ENVIRONMENT;因此集成测试配置仍在该环境选择 2–4 个 Vitest fork,新的资源竞争限制没有作用于 Release。本 PR 补齐这处接线,不修改生产超时,也不弱化测试。Reviewer 测试计划
如何验证
确认 Release 的两个集成测试 job 都会把真实 runner 环境传给集成测试进程。在自托管 runner 上,配置应解析为一个 Vitest fork;在托管 fallback 上,应保持 2–4 个 fork。聚焦的 workflow 与集成配置测试应保持通过。
本地验证:修改的测试文件已通过 ESLint;两个聚焦测试套件共 32 个测试通过、1 个平台条件跳过;Prettier 和
git diff --check均通过。证据(修改前后)
N/A——仅修改 CI workflow 配置。
测试平台
环境(可选)
使用仓库锁定的工具链在本地运行聚焦的 workflow contract 与 Vitest 配置测试。
风险与范围
关联 Issue
Fixes #10535
相关:#10567