Skip to content

fix(test): probe the native directory picker once at daemon spawn time #10456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 1 commit into from
Aug 29, 2026
Merged

fix(test): probe the native directory picker once at daemon spawn time #10456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions integration-tests/cli/qwen-serve-routes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ let homeDir = '';
let port = 0;
let base = '';
let client: DaemonClient;
// The daemon evaluates isNativeDirectoryPickerAvailable() in its own process
// at boot. Probe once at spawn time (same host, same uid, same relevant env)
// so the expectation matches the daemon's boot-time view; re-probing at
// assertion time minutes later diverged when the host's GUI session state
// drifted mid-run (red macOS E2E runs after #9406, tracked in #10453).
let nativeDirectoryPickerAtBoot = false;

function writePersistedTranscript(
sessionId: string,
Expand Down Expand Up @@ -112,6 +118,7 @@ function chatRecord(

beforeAll(async () => {
homeDir = mkdtempSync(path.join(tmpdir(), 'qwen-serve-routes-home-'));
nativeDirectoryPickerAtBoot = isNativeDirectoryPickerAvailable();
daemon = spawn(
process.execPath,
[
Expand Down Expand Up @@ -296,7 +303,8 @@ describe('qwen serve — capabilities envelope', () => {
// `workspace_voice_transcription`, `rate_limit`, `channel_reload`.
// `native_directory_picker` is host-conditional (the daemon host's GUI
// environment, not a spawn flag) and is spliced at its registry
// position below.
// position below, using the boot-time probe captured when the daemon
// was spawned rather than a fresh probe at assertion time.
// Pool tags (`mcp_workspace_pool`, `mcp_pool_restart`) ARE present
// because the workspace MCP pool is on by default, as are
// `workspace_settings`, `workspace_permissions`, `workspace_voice`,
Expand Down Expand Up @@ -414,9 +422,7 @@ describe('qwen serve — capabilities envelope', () => {
'persistent_workspace_registration',
'workspace_display_name',
'workspace_runtime_removal',
...(isNativeDirectoryPickerAvailable()
? ['native_directory_picker']
: []),
...(nativeDirectoryPickerAtBoot ? ['native_directory_picker'] : []),
'workspace_qualified_rest_core',
'extension_management_v2',
'extension_git_credentials',
Expand Down
Loading