Skip to content

ci: serialize helper test files #10371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 3 commits into from
Aug 28, 2026
Merged

ci: serialize helper test files #10371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21d537c
ci: serialize helper test files
yiliang114 Aug 28, 2026
5ba6189
Merge remote-tracking branch 'origin/main' into codex/helper-tests-se…
yiliang114 Aug 28, 2026
11df18d
test(ci): pin helper test serialization
yiliang114 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ jobs:
node scripts/lint.js --setup
node scripts/lint.js --actionlint
node scripts/lint.js --yamllint
node --test ${{ env.HELPER_TESTS }}
node --test --test-concurrency=1 ${{ env.HELPER_TESTS }}
Comment thread
yiliang114 marked this conversation as resolved.

# Avoid setup-node downloads on ECS, where nodejs.org may be unreachable
# through the egress proxy; reuse the machine's Node instead.
Expand Down Expand Up @@ -496,7 +496,7 @@ jobs:
# regression tests. Linux-only (they're platform-independent).
- name: 'Run .github/scripts helper tests'
if: "${{ needs.classify_pr.outputs.skip_ci != 'true' && steps.ci_profile.outputs.ci_profile == 'full' }}"
run: 'node --test ${{ env.HELPER_TESTS }}'
run: 'node --test --test-concurrency=1 ${{ env.HELPER_TESTS }}'

# The install-script packaging suite needs zip/unzip, and throws on a
# CI host that ships neither, so a silent skip there is impossible.
Expand Down
12 changes: 12 additions & 0 deletions scripts/tests/ci-platform-lanes.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,18 @@ describe('platform lanes — the retired sensitivity classifier', () => {
});
});

describe('GitHub helper tests', () => {
it('runs every invocation serially', () => {
const helperSteps = Object.values(ci.jobs)
.flatMap((job) => job.steps ?? [])
.filter((step) => String(step.run ?? '').includes('env.HELPER_TESTS'));
expect(helperSteps).not.toHaveLength(0);
for (const step of helperSteps) {
expect(String(step.run), step.name).toContain('--test-concurrency=1');
}
});
});

describe('platform lanes — a failing nightly is visible', () => {
it('files an issue when the scheduled CI run fails on main', () => {
// A nightly nobody is told about is the same silence the merge-queue gate
Expand Down
Loading