Repository navigation
ci: quarantine platform-stalled E2E suites from push lanes (#10316) #10327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bb73864
ci: quarantine platform-stalled E2E suites from push lanes (#10316)
qwen-code-dev-bot 335690c
Merge branch 'main' into autofix/issue-10316
wenshao a768b69
Merge branch 'main' into autofix/issue-10316
qwen-code-dev-bot 2ff45c4
ci: correct quarantine rationale and harden pin test (#10316)
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment block is rewritten in this round: it no longer cites #10272 as a live platform stall (the issue is closed and its closing comment corrects the platform hypothesis — the stalls were the goal-runtime wait bug fixed by #10290, an ancestor of this PR's merge base) and no longer cites #10316 as a pending root fix. The quarantine is now documented as a precaution, including the ubuntu-latest canary limitation raised alongside this finding: the canaries preserve functional coverage on hosted Linux but provide no signal about the former stall platforms, so lifting the quarantine requires verifying the suites on the affected runners first.
Two parts of the finding are not actionable from inside the repository and are left for the maintainer:
Fixes #10316closing claim — it lives in the PR description on GitHub, which this flow cannot edit (the commit-title reference(#10316)is git history; rewriting it is not allowed here).sdk-typescriptfailures instead, that decision stands above this change.中文说明
本轮已改写该注释块:不再把 #10272 引为存活的平台性卡住(该 issue 已关闭,其关闭评论纠正了平台假设——卡住是 goal-runtime 等待 bug,已由 #10290 修复,且该修复是本 PR 合并基线的祖先),也不再把这个 issue 引为待落地的根因修复。隔离现被记录为稳妥预防措施,并同时写入了随本发现提出的 ubuntu-latest 金丝雀局限:金丝雀仅在托管 Linux 上保留功能覆盖,对原卡住平台不提供任何信号,解除隔离前需先在受影响的 runner 上验证这些套件。
该发现有两部分无法在仓库内完成,留给维护者处理:
Fixes #10316关闭声明——它位于 GitHub 上的 PR 描述中,本流程无权编辑(提交标题中的(#10316)属于 git 历史,此处不允许改写历史)。sdk-typescript的失败,该决定优先于本次改动。