fix(core): clarify user-directed tool cancellation - #10280
Draft
AaronZ345 wants to merge 1 commit into
Draft
Conversation
Make post-completion tool cancellations tell the model to stop and await instructions instead of implying a transient completion race, so Esc is less likely to trigger retries. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Why it's needed
When a user presses Esc while a tool is running, the cancellation can arrive after the tool has already produced output. The previous message only said the tool had already completed and its output was discarded, which can be misread as a transient tool/runtime issue and cause the model to retry. This makes the user intent clear.
Reviewer Test Plan
npm -w @qwen-code/qwen-code-core test -- src/core/coreToolScheduler.test.ts -t "post-completion cancellation"npm -w @qwen-code/qwen-code-core test -- src/core/coreToolScheduler.test.tsnpm -w @qwen-code/qwen-code-core run lintRisk & Scope
Linked Issues
Fixes #10170