fix(core): remove duplicate telemetry test registry stub - #10243
Merged
yiliang114 merged 1 commit intoAug 27, 2026
Conversation
Keep the minimal getToolRegistry mock once so the telemetry swap test double still covers resumed-session initialization without breaking TypeScript compilation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks for isolating this. The duplicate stub currently breaks |
yiliang114
approved these changes
Aug 27, 2026
yiliang114
left a comment
yiliang114
left a comment
Collaborator
There was a problem hiding this comment.
Verified locally: with exactly this removal applied to current main, the full workspace build (npm run build) passes cleanly — this TS1117 was the only compile error. Keeping the #10220 copy with the fuller rationale comment is the right choice. Merging to unbreak main.
yiliang114
marked this pull request as ready for review
August 27, 2026 06:10
yiliang114
requested review from
LaZzyMan,
doudouOUC,
qqqys,
tanzhenxin and
wenshao
as code owners
August 27, 2026 06:10
yiliang114
enabled auto-merge
August 27, 2026 06:10
Collaborator
This was referenced Aug 27, 2026
wenshao
approved these changes
Aug 27, 2026
yiliang114
added a commit
that referenced
this pull request
Aug 27, 2026
… telemetrySwap test) PR CI was red solely due to the pre-existing TS1117 duplicate getToolRegistry in client.telemetrySwap.test.ts (introduced by #10220, fixed by #10243 which is now merged). Syncing main to turn CI green without touching the fix commits. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Collaborator
|
Released in v0.22.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getToolRegistryproperty fromclient.telemetrySwap.test.ts's minimal Config double.restoreLoadedSkillsFromHistorywithout touching a real skill registry.Validation
npm run typecheck --workspace packages/corefailed withTS1117: An object literal cannot have multiple properties with the same namebefore the fix.npm run typecheck --workspace packages/corenpm run build --workspace packages/core && npm run test --workspace packages/core -- src/core/client.telemetrySwap.test.ts --pool threads --maxWorkers 1Closes #10205