docs: fix typo compatability -> compatibility - #10163
Conversation
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
Partially reviewed — gaps disclosed.
Not reviewed: reverse audit — stopped before round 1 by the review time budget.
— qwen3.8-max via Qwen Code /review (v0.22.2)
| ### The two-dot phantom regressions (PR #6626) | ||
|
|
||
| On PR #6626 a review approved four files and then warned the author, publicly, that their branch carried "typo regressions in `ide-client.ts`" and should be rebased. The branch had done nothing: main had corrected `compatability` → `compatibility` after the fork point, and a two-dot diff showed the branch putting the typo back. The PR's real change set, `merge-base..head`, is four files and does not touch that file at all. | ||
| On PR #6626 a review approved four files and then warned the author, publicly, that their branch carried "typo regressions in `ide-client.ts`" and should be rebased. The branch had done nothing: main had corrected `compatibility` → `compatibility` after the fork point, and a two-dot diff showed the branch putting the typo back. The PR's real change set, `merge-base..head`, is four files and does not touch that file at all. |
There was a problem hiding this comment.
[Critical] R1-1: This "typo fix" replaces the wrong occurrence. The backticked compatability on this line is not a typo — it is a deliberate quotation of the historical misspelling inside the PR #6626 anecdote this section records, and it is the left side of the arrow, i.e. the typo the story is about. After this change the sentence reads "main had corrected compatibility → compatibility" — a correction of a word to itself — and the following clause ("a two-dot diff showed the branch putting the typo back") refers to a typo that appears nowhere in the sentence, so the incident this section exists to teach can no longer be reconstructed. The section is cited as measured evidence for the three-dot diff rule at SKILL.md:228 ("(measured; DESIGN.md — The two-dot phantom regressions (PR #6626))"), so every reader and review agent routed there now gets a self-contradictory account. There was no genuine typo to fix: a tree-wide git grep 'compatability' finds exactly 1 match at HEAD~1 — this line — and 0 matches at HEAD, so the PR removed the tree's only, intentional occurrence. The change's effect is the exact inverse of its stated goal.
| On PR #6626 a review approved four files and then warned the author, publicly, that their branch carried "typo regressions in `ide-client.ts`" and should be rebased. The branch had done nothing: main had corrected `compatibility` → `compatibility` after the fork point, and a two-dot diff showed the branch putting the typo back. The PR's real change set, `merge-base..head`, is four files and does not touch that file at all. | |
| On PR #6626 a review approved four files and then warned the author, publicly, that their branch carried "typo regressions in `ide-client.ts`" and should be rebased. The branch had done nothing: main had corrected `compatability` → `compatibility` after the fork point, and a two-dot diff showed the branch putting the typo back. The PR's real change set, `merge-base..head`, is four files and does not touch that file at all. |
Evidence:
- HEAD~1 line 879:
main had correctedcompatability→compatibilityafter the fork point - HEAD line 879:
main had correctedcompatibility→compatibilityafter the fork point - Sweep:
git grep 'compatability' HEAD~1→ 1 match (this line);git grep 'compatability' HEAD→ 0 matches — the PR removed the tree's sole occurrence.
— qwen3.8-max via Qwen Code /review (v0.22.2)
2 participants
One-word typo fix in
packages/core/src/skills/bundled/review/DESIGN.md:879.