chore(cua-driver): bake v0.20.1 into installers - #10141
Open
qwen-code-ci-bot wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
⏳ Approval still deferred — 1 PR CI workflow run(s) still in progress for ⏳ 审批仍在延迟中 —— |
Collaborator
Author
|
Gate check for this release-sync PR. Template: the body is a single line with no template headings. Not gating on it — this is the repo's own release-automation flow, same shape as #6980 (the v0.7.2 bake), which two maintainers approved and merged. The template's reviewer-test-plan content is derivable from the change itself, verified below. Flagging the deviation so a maintainer can speak up if automation PRs should be held to the template too. Problem: real and verified, not theoretical. Release Direction: aligned. This is the established post-release sync flow (the scripts' baked-version markers are documented as "auto-updated after release publication"). Size: no core paths touched — 3 files, +5/−5, all version strings in Approach: minimal, and exactly the established scope — the two baked constants ( Risk: no high-risk path matches (1e). Moving on to code review. 🔍 中文说明发布同步 PR 的准入检查。 模板：正文只有一行，没有模板标题。不做拦截——这是仓库自身的发布自动化流程，与 #6980（v0.7.2 bake）形态一致，该 PR 已由两位 maintainer 批准并合并。模板中"评审者测试计划"的内容可以从改动本身推导，并已在下方核实。此处标记该偏差，如果 maintainer 认为自动化 PR 也应遵守模板，请提出。 问题：真实且已核实，非理论性问题。 方向：对齐。这是既定的发布后同步流程（脚本中的 baked-version 标记明确注明"发布后自动更新"）。 规模：未触及核心路径——3 个文件，+5/−5，均为 方案：最小化，且与既定范围完全一致——两个内嵌版本常量（ 风险：未命中高风险路径（1e）。 进入代码审查 🔍 — Qwen Code · qwen3.8-max Reviewed at |
Collaborator
Author
Code reviewIndependent proposal before reading the diff: bump the two baked version constants the scripts mark as auto-updated after release publication ( Rather than just eyeballing the strings, I verified the whole download path resolves against the published release:
Findings: none. This is the same change shape as #6980, which merged after maintainer review. Test evidenceThe PR's own CI, read via the API — no PR code was executed in this review. The Linux unit suite is still running; macOS/Windows test lanes are skipped by design on Final CI results for
One row per check name (latest run); skipped checks omitted; failures sort first. / 每个检查名一行（取最新一次运行），省略 skipped，失败项排在最前。 Not verified: that the installer runs end-to-end on a fresh machine — the unit suite does not exercise it. Sandboxed verification would settle that residual question if a maintainer wants it: 中文说明代码审查读 diff 前的独立方案：更新两个标记为"发布后自动更新"的内嵌版本常量（ 我没有只看字符串，而是静态验证了整条下载路径与已发布 release 对得上：
结论：无问题。与已合并的 #6980 改动形态一致。 测试证据通过 API 读取 PR 自身 CI——本审查未执行任何 PR 代码。Linux 单元测试仍在运行；macOS/Windows 测试通道在 未验证：安装脚本在全新机器上端到端运行——单元测试不会执行它。如果 maintainer 想闭环这个残余问题，可触发沙箱验证： — Qwen Code · qwen3.8-max Reviewed at |
Collaborator
Author
|
Confidence: 5/5 — mechanical release-sync, verified end to end against the published release; nothing to second-guess. Stepping back: my independent proposal for "sync installers to v0.20.1" was exactly what this PR does — the two baked constants plus the README examples, nothing else. The problem is observed, not theoretical: v0.20.1 shipped today and the default install path still pointed at 0.20.0. The only substantive risk a version bake carries — pointing at a release with no downloadable assets — was checked directly: the tag exists and every asset name both installers construct is present on the release. The diff is the same shape as #6980, which maintainers reviewed and merged, and it would be trivially revertible if 0.20.1 turned out to be bad. No scope creep, no drive-by edits, nothing to maintain later. Verdict: approve. The Linux unit suite is still running, so approval is deferred until CI lands green on 中文说明回顾整体：我对"把安装脚本同步到 v0.20.1"的独立方案与 PR 完全一致——两个内嵌版本常量加 README 示例，别无其他。问题是已观测到的事实：v0.20.1 今天已发布，而默认安装路径仍指向 0.20.0。版本内嵌唯一实质性的风险——指向没有可下载资产的 release——已直接核查排除：tag 存在，两个安装脚本构造的每个资产名在 release 中都存在。diff 与维护者已审查合并的 #6980 形态一致，若 0.20.1 有问题可轻易回滚。无范围蔓延，无顺手改动，无后续维护负担。 结论：批准。Linux 单元测试仍在运行，因此批准推迟至 CI 在被审提交上全部变绿——CI 全绿后 finalize 流程会自动提交绑定该 commit 的批准；若有检查变红或 head 移动，则不会批准。 — Qwen Code · qwen3.8-max Reviewed at |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
Not reviewed: reverse audit — stopped before round 1 by the review time budget.
— qwen3.8-max via Qwen Code /review (v0.22.0)
wenshao
approved these changes
Aug 27, 2026
qqqys
approved these changes
Aug 27, 2026
qqqys
left a comment
qqqys
left a comment
Collaborator
There was a problem hiding this comment.
Approving. Independent check of the diff at head d4070b4cdf: the change is confined to the two designated BAKED_VERSION auto-update blocks (_install-rust.sh, install.ps1) plus the README snippets/expected-output, all consistently moved 0.20.0 → 0.20.1, and the cua-driver-rs-v0.20.1 tag exists upstream. No blocking issues. A maintainer has already approved at this head and CI is green; concur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the default installers and documentation to the published cua-driver-rs v0.20.1 release.