This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Boundaries improvements #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please provide some screenshots showcasing your changes ? |
This commit improves: * Maritime administrative boundaries (reduce width) * Country administrative boundaries (reduce width)
Joxit
changed the title
|
Ok, here are some examples : At zoom 14 near Baarle-Nassau and Baarle-Hertog (Belgium/Netherlands) (For country boundaries) At zoom 17 near Linosa (Island in Italy) (For Coastlines) boundary-land-level-4 was good :) |
|
Much better indeed 👍 And you are right about the coastlines. Can you please remove the styling of the maritime border ? |
|
Without maritime boundaries : Disputed boundaries are already rendered with dashed lines. They are rendered from the zoom 6 (disputed tag are not in tiles from z0 to z5) |
nlehuby
approved these changes
Oct 11, 2018
|
Great job 🥇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for an improvements in boundaries
Changes via taxonomy: before and after
To go further, you should remove the coastlines from your database (they add nothing to the map and make it ugly).