Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associated models to Filters #636

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Allcharles
Copy link
Contributor

Add Association Model to Service Filters

This PR is a potential solution to adding type support to associated models in the service filters. This solution does have some issues however as it requires far more types to execute, and would require a decent sized re-write to the entire app.

Problems

  • Breaks many existing systems
  • Doubles the number of required types to define a service

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Ensure project linter is not producing any warnings (npm run lint)
  • Ensure build is passing on all browsers (npm run test:all)
  • Ensure CI build is passing
  • Ensure docker container is passing (docs)

@Allcharles Allcharles added enhancement New feature or request architecture Architectural changes to the software labels Nov 30, 2020
@github-actions

This comment has been minimized.

Base automatically changed from cleanup-services to master November 30, 2020 03:32
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 065fe91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural changes to the software enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant