Harvest UI tweaks #2033
Harvest UI tweaks #2033
Conversation
hudson-newey
added
bug
hudson-newey
added
dependencies
| public constructor(private injector: Injector) {} | ||
|
|
||
| public ngOnChanges(): void { | ||
| // to inherit mappings values among ancestor items, if the parent item gains a Harvest Mapping, then all the child items should too |
There was a problem hiding this comment.
This method is currently faulty
Since folder rows only have knowledge of their parents, it is not possible to make rows inherit their parents mappings before they are shown on the DOM.
Therefore, I either need to change this.rows to be a doubly linked list (with knowledge of the children, so that I can recurse down the tree when a mapping is changed on a parent item), or move this logic to where the mappings change request is sent to the api (where it does have knowledge of the full model).
| @@ -355,4 +355,7 @@ describe("MetadataReviewComponent", () => { | |||
| discardPeriodicTasks(); | |||
| })); | |||
|
|
|||
| it("should inherit mappings from parent item if harvest item mappings are not set", fakeAsync(() => { | |||
There was a problem hiding this comment.
This unit test needs to be completed
| @@ -84,13 +93,19 @@ interface ValidationMessage { | |||
| ></fa-icon> | |||
| </div> | |||
| </div> | |||
| <ng-container *if="updateChevronState(validationsContainer)"></ng-container> | |||
There was a problem hiding this comment.
This is a hacky workaround I had to implement because change detection wasn't firing for *ngFor changes
There was a problem hiding this comment.
This has now been resolved. It seems to have been an issue with the logic in my updateChevronState method
Harvest UI tweaks
Following a user demo, users expressed that the Harvest UI needed some adjustments
Changes
@angular-devkit/build-angular~in scss importsProblems
This is a draft pull request, I am still debugging, refining, and searching for new bugs.
Issues
Fixes: #1970
Visual Changes
Site id tool tip on hover:
Suggested UTC offsets in dropdown box:
Chevron does not show for single line errors:
New sidebar terminology & action hyperlinks:
Final Checklist
npm run lint)npm run test:all)