Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvest: metadata review screen UI tweaks #1970

Open
11 of 12 tasks
atruskie opened this issue Jul 29, 2022 · 2 comments · May be fixed by #2033
Open
11 of 12 tasks

Harvest: metadata review screen UI tweaks #1970

atruskie opened this issue Jul 29, 2022 · 2 comments · May be fixed by #2033
Assignees
Labels
enhancement New feature or request

Comments

@atruskie
Copy link
Member

atruskie commented Jul 29, 2022

UI tweaks suggested from user demo:

  • Make sure folder guides align on narrow page widths

Image

  • should not show expand chevron for one line problems

Image

  • Show inherited values for mappings instead of a change button

  • Change" Change Site or UTC for folder " to "Add"
    (Combined with the inherited option from above, "change" should never be needed)

  • Do not show root mapping creation button unless there are harvest items in the root directory

  • Add tip into the instruction section that says "You don't have to change anything for files that have no problems"

  • "Upload more files" button should change to "Change or add more files"

  • Duplicate file tip should and a hyperlink to "Change or add more files" button, and make terminology consistent.

    -You should go back to the upload stage and delete the duplicates.
    +You can go back and [change the files] to delete the duplicates
  • Differentiate between duplicates found in this "current upload" and "previous uploads" in tips

  • Show correct site/point terminology in site column

  • Show site id on tooltip hover for select sites

  • UTC offset selector: have common values repeated near the top. E.g.
    For site in NSW:

    +10:00
    +11::00
    ---
    <normal list of offsets here>
    
@atruskie atruskie added the enhancement New feature or request label Jul 29, 2022
@hudson-newey
Copy link
Member

hudson-newey commented Jan 19, 2023

I'm not quite sure what the task

Show inherited values for mappings instead of a change button"

is describing.

I'm assuming that the functionality would work similar to: if you set a mapping for a folder, all sub folders / children under that folder should inherit the mappings. does this sound correct?

I'm also going to be including a fix so that the expand chevron is never ontop of any text (pictured below)
image

Edit: I have completed all the tasks on this issue. I am currently performing a code cleanup and will submit a PR once the code quality is acceptable.

@hudson-newey
Copy link
Member

I have also been able to reproduce the following visual bug on Firefox (not yet tested on chrome). I am going to be fixing this too in the following PR.

image

@hudson-newey hudson-newey linked a pull request Jan 25, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants