Improves support for SM4s #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds high precision timer support for SM4s. Fixes #330 - Adds support for microphone sensitivity reporting for Sm4s partially addressed #331 - Adds make, model, and sensor name for SM4. Partially addresses #296 - BREAKING change: resets channel identifier to match industry standard. i.e. the first channel is 0 (left). We were counting from 1 which is not the most popular format: https://en.wikipedia.org/wiki/Surround_sound#Channel_notation - BREAKING: Fixed a bug with the Location parsing code! Coordinates from WA sensors will now report the correct hemisphere
atruskie
added
bug
hudson-newey
approved these changes
Mar 9, 2023
|
|
||
| if (wamdData.FileStartTime is not null) | ||
| { | ||
| if (wamdData.FileStartTime.Value.Case is OffsetDateTime o) |
There was a problem hiding this comment.
Possible rename o to a more descriptive name?
I had to read the proceeding lines of code to figure out how o was used
There was a problem hiding this comment.
hmmm this is a common convention for temporary variables that created just due to a cast. Here o it is just the cast value of wamdData.FileStartTime. However, any example of something difficult to read takes priority
hudson-newey
approved these changes
Mar 9, 2023
Update src/Emu/Meta.cs Update src/Emu/Audio/VendorExtensions.cs Co-Authored-By: hudson-newey <[email protected]>
atruskie
force-pushed
the
sm4-high-precision
branch
from
b5f7372 to
d40c76d
Compare
|
Hi Anthony, have you already released this change? |
|
Not yet, I'm doing one more feature and then I'll release. It was way harder than expected but it should be worth it |
|
Awesome. Thanks Anthony. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds high precision timer support for SM4s. Fixes Sub-second precision in SM4 #330
Adds support for microphone sensitivity reporting for Sm4s partially addressed Extracting sensitivity and gain for SM4 #331
Adds make, model, and sensor name for SM4. Partially addresses Metadata: fill vendor and sensor name fields #296
BREAKING change: resets channel identifier to match industry standard. i.e. the first channel is 0 (left). We were counting from 1 which is not the most popular format: https://en.wikipedia.org/wiki/Surround_sound#Channel_notation
BREAKING: Fixed a bug with the Location parsing code! Coordinates from WA sensors will now report the correct hemisphere