Fixes multiple assignment bug #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #679 `<<` instantly saves the added association. We were adding the project from the route parameter onto the site object temporarily, assuming the site would not be saved. Instead whenever the route was accessed with any project id, that project id was added to the list of available projects - creating an security bypass. I also took this opportunity to disallow the creation of new sites that belong to multiple projects. It is a feature we plan to remove anyway. We still have to allow updating multi-project sites - at least until we can ensure there are no examples of them in the database.
hudson-newey
approved these changes
Aug 8, 2024
spec/requests/sites_spec.rb
Outdated
| @@ -35,7 +35,8 @@ | |||
| expect_error(400, 'Site testy test site () is not in any projects.') | |||
| end | |||
|
|
|||
| example 'can create an a site that belongs to multiple projects' do | |||
| # AT 2024: soft-deprecating the many to many project-site relationship | |||
| example 'canNOT create an a site that belongs to multiple projects' do | |||
There was a problem hiding this comment.
Suggested change
| example 'canNOT create an a site that belongs to multiple projects' do | |
| example 'cannot create an a site that belongs to multiple projects' do |
I'm debating whether this was purposeful or a typo
I've had a look at other examples where we have used "cannot" inside tests, and this doesn't seem to be the convention
baw-server/spec/models/question_spec.rb
Line 47 in 40eb800
There was a problem hiding this comment.
it wa purposeful - i'll make it more grammatically correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679
<<instantly saves the added association. We were adding the project from the route parameter onto the site object temporarily, assuming the site would not be saved.Instead whenever the route was accessed with any project id, that project id was added to the list of available projects - creating an security bypass.
I also took this opportunity to disallow the creation of new sites that belong to multiple projects. It is a feature we plan to remove anyway.
We still have to allow updating multi-project sites - at least until we can ensure there are no examples of them in the database.