Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General changes to audio_recording model #544

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Allcharles
Copy link
Collaborator

@Allcharles Allcharles commented Oct 25, 2021

Implementing Audio Recording routes

This branch was intended for enabling access to the missing Audio Recording routes described in #443. Changes are partially complete. Some issues are exposed by this change, which will need to be reverted before merging to remain consistent with repo general styling.

Changes

  • Cleanup permitted_attributes
  • Added fields and schema attributes to audio_recording
  • Simplified filter_settings for audio_recording
  • Updated project schema
  • Added README to demystify models
  • Added additional schema types
  • Fixed a bug in the POST method handling where empty request body's could crash the handler
  • Created additional tests for audio recording routes
  • Added audio recording schema to swagger

Problems

  • New audio recording tests fail
  • Changes to audio recording controller will likely need to be reverted

Issues

Relates to #443

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Remove/Reduce warnings from edited files
  • Unit tests have been added for changes
  • Ensure CI build is passing

- Cleanup permitted_attributes
- Added fields and schema attributes to audio_recording
- Simplified filter_settings for audio_recording
- Updated project schema
- Added README to demystify models
- Added additional schema types
- Fixed a bug in the POST method handling where empty request body's could crash the handler
- Created additional tests for audio recording routes
- Added audio recording schema to swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant