Fix bad migration logic

file_hash was required in the schema but when the migration ran in production it failed because the values did not supply a file_hash.

We're just going to use application constraints instead,

README.md

@@ -256,6 +256,6 @@ Other major credits go to:
 - [@Allcharles](https://github.com/Allcharles)
 - [@JessieLOliver](https://github.com/JessieLOliver) for design and user experience feedback
 
-## Licence
+## License
 
 Apache License, Version 2.0

app/helpers/cms_helpers.rb

@@ -20,7 +20,7 @@ def organisation_name
   def address(not_logged_in_message = '')
     return not_logged_in_message unless current_user
 
-    Settings&.organisation_names&.address || '<address not configured>'
+    Settings.organisation_names&.address || '<address not configured>'
   end
 
   def cms_page_label

app/models/audio_event_import_file.rb

@@ -6,7 +6,7 @@
 #
 #  id                                                                                             :bigint           not null, primary key
 #  additional_tag_ids(Additional tag ids applied for this import)                                 :integer          is an Array
-#  file_hash(Hash of the file contents used for uniqueness checking)                              :text             not null
+#  file_hash(Hash of the file contents used for uniqueness checking)                              :text
 #  path(Path to the file on disk, relative to the analysis job item. Not used for uploaded files) :string
 #  created_at                                                                                     :datetime         not null
 #  analysis_jobs_item_id                                                                          :integer

baw-server.code-workspace

@@ -25,6 +25,7 @@
       "binmode",
       "binread",
       "binstub",
+      "binstubs",
       "birdnet",
       "Boobook",
       "boolify",
@@ -280,7 +281,7 @@
       "editor.defaultFormatter": "castwide.solargraph",
       //"editor.defaultFormatter": "rebornix.ruby"
     },
-    "cSpell.enableFiletypes": [
+    "cSpell.enabledFiletypes": [
       "ruby"
     ],
     "editor.minimap.size": "fill",

db/migrate/20240524011344_audio_event_import_files.rb

@@ -22,7 +22,10 @@ def change
 
       t.datetime :created_at, precision: 6, null: false
 
-      t.text :file_hash, null: false, comment: 'Hash of the file contents used for uniqueness checking'
+      # Hudson says: because we have to migrate the data, and the previous data did not have a file_hash
+      # we must allow nulls here. Sticking in a fake non-null value would be a bad idea.
+      # Non-nullness will be enforced in the application.
+      t.text :file_hash, null: true, comment: 'Hash of the file contents used for uniqueness checking'
     end
 
     change_table :audio_event_imports do |t|
@@ -41,8 +44,8 @@ def change
 
         # create a default audio_event_import_file for each audio_event_import
         query = <<~SQL.squish
-          INSERT INTO audio_event_import_files (audio_event_import_id, created_at, path)
-          SELECT id, created_at, 'default' FROM audio_event_imports;
+          INSERT INTO audio_event_import_files (audio_event_import_id, created_at, path, file_hash)
+          SELECT id, created_at, 'default', null FROM audio_event_imports;
         SQL
 
         execute(query)

db/structure.sql

@@ -568,7 +568,7 @@ CREATE TABLE public.audio_event_import_files (
     path character varying,
     additional_tag_ids integer[],
     created_at timestamp(6) without time zone NOT NULL,
-    file_hash text NOT NULL,
+    file_hash text,
     CONSTRAINT path_and_analysis_jobs_item CHECK ((((path IS NOT NULL) AND (analysis_jobs_item_id IS NOT NULL)) OR ((path IS NULL) AND (analysis_jobs_item_id IS NULL))))
 );