Fixes bug in multi recogniser #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multirecogniser was not outputting any events after the component recognizers detected events. The fix was simply to ensure NewEvents were aggregated as well as old style AcousticEvents. Also: - wrote tests for the multi recognizers - ensured that multiple different ways of specifying sub-recognizers would work (name, soft-resolved config, absolute reference to files) - also ensured configs were loaded before the main analysis starts - this should produce much nicer error messages and avoid cutting audio before telling the user about the inevitable failure. - fixed the path to analysis programs in the test metdadata helper Fixes #97
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=========================================
- Coverage 0.71% 0.70% -0.02%
=========================================
Files 481 481
Lines 48928 48973 +45
Branches 7678 7684 +6
=========================================
- Hits 350 344 -6
- Misses 48527 48579 +52
+ Partials 51 50 -1
Continue to review full report at Codecov.
|
It acts like a Recognizer and thus must be of type RecognizerConfig. My attempt to generalize the concept in 9c95fa5 was misguided
|
I don't know how to review this efficiently and some of the syntax I am not familiar with. However, I checked MultiRecognizer.cs and the test file, MultiRecogniserTests.cs and got the gist. You needed to update NewEvents . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in multi recogniser
The multirecogniser was not outputting any events after the component recognizers detected events. The fix was simply to ensure NewEvents were aggregated as well as old style AcousticEvents.
Changes
Also:
Issues
Fixes #97
Visual Changes
N/A
Final Checklist