Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in EventFilters.cs #475

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

towsey
Copy link
Contributor

@towsey towsey commented Apr 9, 2021

See Issue #466 - Fix bug in EventFilters.cs

Changes

Shifted two lines of code to correct location i.e. after necessary checks have determined the list contains something to write.

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Link any PRs or issues blocking this PR from being merged
  • Remove/Reduce warnings from edited files
  • [X ] no unit tests affected.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #475 (9cda490) into master (eadb4b1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #475      +/-   ##
=========================================
- Coverage    0.71%   0.70%   -0.02%     
=========================================
  Files         471     471              
  Lines       48647   48647              
  Branches     7667    7667              
=========================================
- Hits          350     344       -6     
- Misses      48246   48253       +7     
+ Partials       51      50       -1     
Impacted Files Coverage Δ
src/AudioAnalysisTools/Events/EventFilters.cs 0.00% <0.00%> (ø)
src/Acoustics.Shared.FSharp/matrix.fs 4.99% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadb4b1...9cda490. Read the comment docs.

@atruskie atruskie merged commit 17a6c1c into master Apr 9, 2021
@atruskie atruskie deleted the Issue466-FixWritingOfVoidList branch April 9, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants