Setting default FFT window to Hanning #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #291 Have set the default FFT window to Hanning for calculation of all summary and spectral indices. However left the Test methods using HAMMING window so do not have to make changes to the output.
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 29.30% 29.34% +0.04%
==========================================
Files 475 475
Lines 68794 68826 +32
==========================================
+ Hits 20158 20198 +40
+ Misses 48636 48628 -8
Continue to review full report at Codecov.
|
|
@towsey this introduced multiple test failures. See https://dev.azure.com/QutEcoacoustics/audio-analysis/_build/results?buildId=2193&view=ms.vss-test-web.build-test-results-tab While you're fIxing those tests, maybe consider how we could make them less fragile? |
1 task
|
Hi Anthony,
Clicking the link you provided does not take me to the failed test info.
Suggestion?
|
|
It looks like the build number changed 🤷♂️. The link above works |
atruskie
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #291 Have set the default FFT window to Hanning for calculation of all summary and spectral indices.
However left the Test methods using HAMMING window so do not have to make changes to the output.
Title of PR
What is the purpose of this PR?
Changes
List of changes added as part of this PR. This only needs to include the big changes which reviewers should carefully check.
Issues
Any issues caused by the PR that will need to be addressed in another PR.
These issues may be caused by another branch which will change how this branch functions.
Visual Changes
If the PR has any visual changes to the website, post pictures of the new pages and how they look.
Label any images if more than one is given.
Final Checklist