Issue292 spectral centroid #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #292 SC is to be used as a summary index.
Issue #292 Write various methods to calculate the spectral centroid of a spectrum and accompanying unit tests of the methods.
…the Summary Indices Issue #292 Incorporate calculation of the Spectral Centroid into calculation of the Summary Indices. Also incorporate the calculation into unit test of summary indices.
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 29.19% 29.31% +0.11%
==========================================
Files 474 475 +1
Lines 68728 68794 +66
==========================================
+ Hits 20066 20165 +99
+ Misses 48662 48629 -33
Continue to review full report at Codecov.
|
atruskie
approved these changes
Jul 6, 2020
|
Also there'a failing unit test at |
Issue #292 Added in reference to literature to justify calculation of the spectral centroid and fix a failing unit test.
|
Hi Anthony,
I have fixed both the issues which you mentioned concerning spectral centroid. The unit test now passes.
Cheers, Michael
Dr. Michael Towsey
ORCID iD http://orcid.org/0000-0002-8246-7151
QUT Ecoacoustics Research Group | www.Ecosounds.org<http://www.ecosounds.org/>
Science and Engineering Faculty
S block, Level 10, Room 1002, Garden Point Campus,
Queensland University of Technology,
Brisbane, Queensland 4001
Australia
Phone +61 7 3138 9381
Fax +61 7 3138 9390
…________________________________
From: Anthony Truskinger <[email protected]>
Sent: 06 July 2020 6:13 PM
To: QutEcoacoustics/audio-analysis <[email protected]>
Cc: Michael Towsey <[email protected]>; Author <[email protected]>
Subject: Re: [QutEcoacoustics/audio-analysis] Issue292 spectral centroid (#330)
Also there'a failing unit test at Acoustics.Test.Shared.CsvTests.TestBaseTypesAreNotSerializedAsArray() - that test is just testing CSV output, you'll just need to add your new column to the expected string.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/QutEcoacoustics/audio-analysis/pull/330*issuecomment-654086064__;Iw!!NVzLfOphnbDXSw!UGiBHa6M39dv01RUfTqb0Ut6Xwe8dGh4ZwC1Hb5GfRjBvSyzdPRUE87TAr-COpR5x7s$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABXG7A7VXA7ZS46WYZHXK73R2GBTFANCNFSM4ORKPTVQ__;!!NVzLfOphnbDXSw!UGiBHa6M39dv01RUfTqb0Ut6Xwe8dGh4ZwC1Hb5GfRjBvSyzdPRUE87TAr-CuzNLPZI$>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title of PR
Issue #292 Spectral Centroid
What is the purpose of this PR?
To incorporate calculation of Spectral centroid as summary index into master.
Changes
Calculation of centroid and associated unit tests.
Visual Changes
An additional track should be added into the image of the summary indices.
Closes #292