Short name app config fix #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #241 When R executes AP.exe it uses the `Sys.which` function to resolve the executable name. This function uses the Windows 8.3 short-name functionality by defualt which launches the application as ANALYS~1.exe. Since the application is no longer named correctly, the AnalysisPrograms.exe.config file cannot be loaded and all of our application binding redirects are ignored. Subsequently the fusion assembly loader throws errors like: ``` System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. - Could not load file or assembly 'System.Numerics.Vectors, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040) ``` In addition to the stack overflow post that should how to update the current domain's App.Config file and settings, I also had to force Fusion to redo it's setup. This method, is to say the least, fragile, and we can expect it to fail in the port to .NET Core. Additionally added a AP_DEFAULT_LOG_VERBOSITY flag that set the log level verbosity before the command line is parsed. Additionally added a few extension method helpers and associated tests
Collapsed two similar files into one, removed a bunch of old (and faulty) "CSV" parsing methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
When R executes AP.exe it uses the
Sys.whichfunction to resolve the executablename. This function uses the Windows 8.3 short-name functionality by default which
launches the application as ANALYS~1.exe. Since the application is no longer named
correctly, the AnalysisPrograms.exe.config file cannot be loaded and all of our
application binding redirects are ignored. Subsequently, the fusion assembly loader
throws errors like:
In addition to the stack overflow post that should how to update the current domain's
App.Config file and settings, I also had to force Fusion to redo its setup. This method
is, to say the least, fragile, and we can expect it to fail in the port to .NET Core.
Additionally added a AP_DEFAULT_LOG_VERBOSITY flag that set the log level verbosity
before the command line is parsed.
Additionally added a few extension method helpers and associated tests