Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ImageChrome option in SpectrogramFalseColourConfig #352

Closed
atruskie opened this issue Aug 4, 2020 · 1 comment · Fixed by #503
Closed

Expose ImageChrome option in SpectrogramFalseColourConfig #352

atruskie opened this issue Aug 4, 2020 · 1 comment · Fixed by #503
Assignees
Milestone

Comments

@atruskie
Copy link
Member

atruskie commented Aug 4, 2020

Is your feature request related to a problem? Please describe.

Sometimes I'd like to produce a FCS without any of the axes, legends, or gridlines.

Describe the solution you'd like

Expose the internal ImageChrome option of the FCS rendering methods by adding a config file property in SpectrogramFalseColourConfig.

Describe alternatives you've considered

N/A

Additional context

This issue was filed on behalf of an external collaborator.

@atruskie atruskie added this to the August milestone Aug 5, 2020
@mtchl
Copy link

mtchl commented Feb 8, 2021

Hey I would really like this functionality too. I'm hoping to include some FCS in a web application so plain images would be ideal

@atruskie atruskie self-assigned this Jun 28, 2021
atruskie added a commit that referenced this issue Jun 28, 2021
- Adds a shared items project for config files so they are visible in the Visual Studio solution  explorer
- Adds ImageChrome option to config files and LDSpectrogramRGB
- Refactors LDSpectrogramRGB so that greyscale and FCS  images output at the same size, and use common global constants
- LDSpectrogramRGB will now save a chromeless image to disk if chromeless is requested (previously it would return just the chromeless image and save the chromed image to disk)

Fixes #352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants