-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Intention] New Event Architecture #310
Labels
Comments
It is worth noting that other component events are likely to arise. |
atruskie
added a commit
that referenced
this issue
Apr 11, 2020
Work done for #310. Additionally wrote more tests for buggy ImageSharp line drawing. Fixed bugs in LinearScale and added more unit tests.
atruskie
added a commit
that referenced
this issue
Apr 14, 2020
Work done for #310 - adjust clamp so it can deal with negative ranges - fix inset border method - add a fill with blend method to compensate for unexpected imagesharp behaviour when belnding pixels in rgb24 images - Fix a bug in getting point data coordinates from unit coverter
atruskie
added a commit
that referenced
this issue
Apr 15, 2020
Work done for #310. - Improves our NoAA draw line method to handle more buggy behaviour - Added ToString human friendly display to spectral point - Improves and tests track drawing behaviour for the line drawing case - Added a utility constructor to Track - Changed the offset times in unit converters - Added tests for the spectral point comparer - Add dot syntax to represent empty spots on a test image - easier to use when showing a test image as a full grid of 'text pixels'
atruskie
added a commit
that referenced
this issue
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
A feature request. Our current
AcousticEvent
class is a poorly-designed one-size-fits-all mess that has been evolved over the entire lifetime of the code base. We want to add more structure to the types of events we detect and report but it will be difficult to add more intoAcousticEvent
Describe the solution you'd like
@towsey and I have created the following proposal for a new Event hierarchy. It will allow use encode events with more data, to visualise them better, and to make testing and maintaining the code easier over time.
The intention is that this structure will replace and deprecate
AcousticEvent
over time.Describe alternatives you've considered
We could augment
AcousticEvent
but there is a lot of old code that depends on it's behaviour and quirks. It'd take weeks to fix it all. Our suggested approach would give us the benefits of our new structure now, while allowing us to move away fromAcousticEvent
over time.Additional context
@towsey and I have discussed this extensively but we are open to further feedback. Please let us know.
We also want to map ontologies for:
but both of these can be added in later via associations and don't need to modelled as part of the event inheritance hierarchy.
The text was updated successfully, but these errors were encountered: