Broken Oscillations test #146
Assignees
Labels
Comments
atruskie
added a commit
that referenced
this issue
Feb 15, 2018
The work done in 864f7a4 to reorganize the solution for our open source release (see #140) was left incomplete because various dependencies needed to be replaced. This commit fixes nearly all tests (with the exception of one test which is now detailed in #146). This commit also: - Replaces our chosen cloning library (GerorgeCloney) with a newer one that can clone `FileInfo`s via reflection - Fixes a bug from 72aab48 where `FrequencyScaleType` property did not match the name used in the config files - The changed FFT calculation produced very very small changes in anything that depends on the FFT. I either recalculated our expected binary matrices, or for most failing cases added a delta threshold to the comparison. I found 1E-9 was plenty of delta and three orders of magnitude smaller than any change we could notice - I adjusted the build to ensure audio tools are copied to test output
towsey
added a commit
that referenced
this issue
Oct 30, 2018
Create new Spectral index to detect oscillations Fix existing tests for oscillaitons spectrogram and create new test for oscillations spectral index. Still more work to be done with this issue. Partly fixes issue #146
|
Closed in c916037 |
atruskie
pushed a commit
that referenced
this issue
Dec 19, 2018
Needed to make changes to Index calculate to add this to list of spectral indices Attending Issue #146 Oscillations test This commit and the previous 7 commits have all to do with Issue #146. In this commit set up the IndexCaltulate test to include the new OSC spectral index. This issue #146 should now be closed except that we still hvae to check how the index is working to produce LDFC spectrograms.
atruskie
pushed a commit
that referenced
this issue
Dec 19, 2018
Needed to make changes to Index calculate to add this to list of spectral indices Attending Issue #146 Oscillations test This commit and the previous 7 commits have all to do with Issue #146. In this commit set up the IndexCaltulate test to include the new OSC spectral index. This issue #146 should now be closed except that we still hvae to check how the index is working to produce LDFC spectrograms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behaviour
The
Acoustics.Test.AudioAnalysisTools.Oscillations2014.OscillationTests.TwoOscillationTeststest method should pass.Actual behaviour
The test currently fails. The changes to the FFT generation code in 864f7a4 broke it and I don't have the knowledge to fix it.
The text was updated successfully, but these errors were encountered: