Skip to content

Commit

Permalink
Refactored .NET Core solution
Browse files Browse the repository at this point in the history
- defined common props in Directory.Build.props
- removed dependancy on .NET Framework and MSBuild Community Tasks and replaced git versioning tasks with a powershell script.
- locked .net core to stable release in global.json to avoid a bug with FSharp project SDK not being able to parse a nuget version
- Reinstalled stylecop project reference into all projects
- renabled deterministic builds on FSharp projects by chaning output type to PDB
- Disabled short name tests because I could not determine any valid test or faulting case that still occurs (see #241)
- Removed vagrant file - soon will not be necessary
  • Loading branch information
atruskie committed Feb 19, 2020
1 parent 248163f commit bb1c4c6
Show file tree
Hide file tree
Showing 33 changed files with 217 additions and 21,016 deletions.
10 changes: 7 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,24 @@ Required Software

The required software for developing new code (not running the program) includes:

- A PowerShell Core (version 6+) install
- You can install it from here: https://github.com/powershell/powershell#get-powershell
- The latest .NET Core SDK
- You can download it from here: https://dotnet.microsoft.com/download/dotnet-core/
- An IDE:
- Visual Studio 2019 (Windows only)
- .NET Core SDK for Visual Studio 2019
- Install features:
- C# Development
- .NET Core SDK for Visual Studio 2019
- If you're at a university that has an Office365 Subscription you can download software from https://azureforeducation.microsoft.com/devtools
- The [community edition](https://visualstudio.microsoft.com/vs/) of Visual Studio should work fine and is totally free
- [Optional] Resharper Ulitmate (Academic License)
- Install these plugins (_ReSharper_ menu > _Extension Manager_)
- ReSpeller Free
- VS Code
- C# Extension

- [msysgit](https://git-for-windows.github.io/)
- msysgit or a git executable on PATH
- https://git-for-windows.github.io/

Binary Large Objects (BLOBs)
----------------------------
Expand Down
15 changes: 15 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<Project>
<PropertyGroup>
<Deterministic>true</Deterministic>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)style.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>
<ItemGroup>
<AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json">
<Link>stylecop.json</Link>
</AdditionalFiles>
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.164">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
</Project>
72 changes: 0 additions & 72 deletions Vagrantfile

This file was deleted.

6 changes: 6 additions & 0 deletions build.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env pwsh

#Requires -Version 6


Write-Output "Empty stub, do not use yet"
52 changes: 0 additions & 52 deletions build/build.ps1

This file was deleted.

5 changes: 5 additions & 0 deletions global.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"sdk": {
"version": "3.1.101"
}
}
Binary file removed src/.build/MSBuild.Community.Tasks.dll
Binary file not shown.
Loading

0 comments on commit bb1c4c6

Please sign in to comment.