Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add file name to knowledge properties in crawl_endpoint #3346

Conversation

StanGirard
Copy link
Collaborator

The crawl_endpoint function in crawl_routes.py now includes the file_name property in the knowledge_to_add object. This change ensures that the file name is properly associated with the crawled knowledge, improving the accuracy and organization of the data.

Co-authored-by: Stan Girard [email protected]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

The `crawl_endpoint` function in `crawl_routes.py` now includes the `file_name` property in the `knowledge_to_add` object. This change ensures that the file name is properly associated with the crawled knowledge, improving the accuracy and organization of the data.

Co-authored-by: Stan Girard <[email protected]>
Copy link

linear bot commented Oct 8, 2024

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:07pm

@StanGirard StanGirard marked this pull request as ready for review October 8, 2024 14:07
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory labels Oct 8, 2024
@StanGirard StanGirard merged commit eea702d into main Oct 8, 2024
8 checks passed
@StanGirard StanGirard deleted the feature/ent-111-erreur-reseau-lors-du-crawling-de-5-pages-de-la-doc-quivr branch October 8, 2024 14:12
StanGirard added a commit that referenced this pull request Oct 8, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.321 (2024-10-08)

## What's Changed
* feat: Add file name to knowledge properties in crawl_endpoint by
@StanGirard in #3346
* feat(frontend): add xlsx by @Zewed in
#3340


**Full Changelog**:
v0.0.320...v0.0.321

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant