Devx/add linter rules #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gozineb
force-pushed
the
devx/add-linter-rules
branch
from
b8ae715 to
3b7c05d
Compare
gozineb
force-pushed
the
devx/add-linter-rules
branch
from
3b7c05d to
9e61742
Compare
gozineb
force-pushed
the
devx/add-linter-rules
branch
from
9e61742 to
8145c4f
Compare
frontend/lib/components/ui/Modal.tsx
Outdated
Comment on lines
62
to
64
| <Dialog.Close asChild> | ||
| {CloseTrigger ? ( | ||
| {CloseTrigger === true ? ( | ||
| CloseTrigger |
Comment on lines
32
to
52
| // export const googleModels = ["vertexai"] as const; // TODO activate when not in demo mode | ||
|
|
||
| // export const googleModels = [] as const; | ||
| export const googleModels = [] as const; | ||
| export const models = [ | ||
| ...openAiModels, | ||
| ...anthropicModels, | ||
| ...googleModels, | ||
| ] as const; | ||
|
|
||
| export const paidModels= [ | ||
| ...openAiPaidModels, | ||
| ...googleModels, | ||
| ] as const; | ||
| export const paidModels = [...openAiPaidModels] as const; |
There was a problem hiding this comment.
More than linting here... sure ?
gozineb
force-pushed
the
devx/add-linter-rules
branch
from
8145c4f to
7d5f4bc
Compare
gozineb
force-pushed
the
devx/add-linter-rules
branch
from
7d5f4bc to
55242c7
Compare
gozineb
force-pushed
the
devx/add-linter-rules
branch
from
f0bd722 to
b40da13
Compare
StanGirard
pushed a commit
that referenced
this pull request
Sep 12, 2023
* remove duplicate import * 🚧 add new linter configuration * 🧑💻 add and run prettier * 🐛 add babel parser for linter * 🧑💻 add lint-fix command * 🚨 use lint-fix * 🚨 remove 'FC' as a type. Use const and JSX.Element * 🚨 enforce arrow function rule from linter * 🔥 delete unused file * 🚨 adding /* eslint-disable */ in failing files * 💩 add ts-expect-error to Victory components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):