-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integration): Notion #3173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Checklist before requesting a review Please delete options that are not relevant. - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented hard-to-understand areas - [ ] I have ideally added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged ## Screenshots (if appropriate):
The generate_source function in the rag_service/utils.py file had a bug that caused an error when generating the source URL for a document. This bug has been fixed by adding exception handling around the code that generates the URL. Now, if an error occurs during URL generation, the function will log an error message and continue to the next document.
# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Checklist before requesting a review Please delete options that are not relevant. - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented hard-to-understand areas - [ ] I have ideally added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged ## Screenshots (if appropriate):
# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Checklist before requesting a review Please delete options that are not relevant. - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented hard-to-understand areas - [ ] I have ideally added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged ## Screenshots (if appropriate):
The 'state' parameter in the sync routes of various providers (Azure, Dropbox, GitHub, Google, Notion) is no longer used and has been commented out. This change removes the unused parameter to improve code clarity and maintainability.
Remove the unused 'status' parameter in the setup_syncs_data function in the sync tests module. The parameter is not being used and can be safely removed to improve code clarity and maintainability.
StanGirard
added a commit
that referenced
this pull request
Sep 30, 2024
The code changes in `sync.py` update the Redis client configuration to use the `CELERY_BROKER_URL` environment variable. This allows for more flexibility in specifying the Redis connection details. Recent user commits: - chore: update Dockerfile dependencies and copy files - feat: update sync_user.py to include sync user id in aget_files call (#3276) - fix: add sync user id aget_files (#3261) - fix: correctly passing the prompt provided by the user (#3252) - fix(frontend): sync folder for premium users (#3251) - fix: wrong default path for CHAT_LLM_CONFIG_PATH env variable (#3247) - feat: introducing configurable retrieval workflows (#3227) - feat: remove n+1 query knowledge (#3238) - fix(migration): order migrations (#3231) - feat(integration): Notion (#3173) Recent repository commits: - chore: update Dockerfile dependencies and copy files - feat: update sync_user.py to include sync user id in aget_files call (#3276) - fix: add sync user id aget_files (#3261) - fix: correctly passing the prompt provided by the user (#3252) - fix(frontend): sync folder for premium users (#3251) - fix: wrong default path for CHAT_LLM_CONFIG_PATH env variable (#3247) - feat: introducing configurable retrieval workflows (#3227) - feat: remove n+1 query knowledge (#3238) - fix(migration): order migrations (#3231) - feat(integration): Notion (#3173) ```
StanGirard
added a commit
that referenced
this pull request
Sep 30, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.316 (2024-09-30) ## What's Changed * fix(core): enforce langchain <0.3 for pydantic v1 by @StanGirard in #3217 * chore(main): release core 0.0.16 by @StanGirard in #3218 * feat(assistants): mock api by @StanGirard in #3195 * chore(examples): fix chainlit example by @StanGirard in #3223 * feat(integration): Notion by @chloedia in #3173 * fix(migration): order migrations by @StanGirard in #3231 * feat: remove n+1 query knowledge by @AmineDiro in #3238 * feat: introducing configurable retrieval workflows by @jacopo-chevallard in #3227 * fix: wrong default path for CHAT_LLM_CONFIG_PATH env variable by @jacopo-chevallard in #3247 * fix(frontend): sync folder for premium users by @Zewed in #3251 * fix: correctly passing the prompt provided by the user by @jacopo-chevallard in #3252 * fix: add sync user id aget_files by @AmineDiro in #3261 * feat: update sync_user.py to include sync user id in aget_files call by @StanGirard in #3276 * chore: update Dockerfile dependencies and copy files by @StanGirard in #3277 * chore: add wget to Dockerfile dependencies by @StanGirard in #3279 **Full Changelog**: v0.0.315...v0.0.316 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: backend
Related to backend functionality or under the /backend directory
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix multiple notion bugs 👍
-> Delete your notion sync and all the notion files from the db
-> Ensure a sync is not already running before launching a sync.
-> Add a status to subscribe to for user_sync