Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solves #2695 #2696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

solves #2695 #2696

wants to merge 1 commit into from

Conversation

AmineDiro
Copy link
Collaborator

Description

solves #2695

  • Add retries up to 5 times
  • Adds exponential backoff
  • Raises HTTP exception if connection can't be made

@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:01pm

@AmineDiro AmineDiro marked this pull request as ready for review June 20, 2024 14:59
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory labels Jun 20, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

StanGirard
StanGirard reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@StanGirard StanGirard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne mettrais qu'un seul retry car c'est user facing.

@AmineDiro
Copy link
Collaborator Author

Bonne remarque. Normalement si l'api marche on peut avoir le retour directement mais si ca fail on devrait retester. Je pense que le exponential backoff peut etre supprimé. Avoir un fixed interval serait mieux adapté

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanGirard StanGirard StanGirard left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmineDiro @StanGirard