Formalize Quilt mod metadata handling #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
added a commit
to Juuxel/fabric-loom
that referenced
this pull request
Jul 19, 2023
See: - RFC: QuiltMC/rfcs#83 - Build tool impl: QuiltMC/quilt-loom#36, QuiltMC/quilt-loom#37 - Required loader PR: QuiltMC/quilt-loader#329
|
Closing this, considering that this piece of bureaucracy, despite how surprisingly well-written it is, is no longer necessary; It can be reconsidered later as a descriptive specification if needed, but in the hindsight? This RFC was only required to be written because someone had maliciously used bureaucracy as a personal veto to the whole project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With plans to introduce support for
quilt.mod.json5(through quilt-loader#329 and quilt-loom#36) in a limited capacity within the toolchain, formalizing how metadata should be handled has been needed. This formalizes the mandatory need to handlequilt.mod.jsonand the optional need of handlingquilt.mod.json5Considering that we are on a "down with bureaucracy" arc, I'd rather have this RFC be an explainer of things already been put in place, rather than as a precondition before we can move forward with QMJ5. I will, however, consider it as a precondition for further pushing of the format, with Quilt Template Mod waiting for a proper unveiling of the format before adopting it itself