Refactor in preparation for supporting POI and ENTITIES MCA files #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
added 28 commits
April 30, 2024 21:47
… (nether portals are recorded in POI's)
… name assertLoadFLag. Completed test testChunkSectionMinMaxSectionY which was accidentally left incomplete in previous commit. ChunkIterator added currentWorldX/Z getters. Moved deserializeChunk impl from MCAFile into MCAFileBase
…ATORS for customization
…to be abel to customize the behavior of the "auto" factory methods in MCAUtil
…ior is now to use the current timestamp Adding MCAFileBase#removeChunk Mostly finalized POI support implementation Starting POI support unit tests and started setting up abstract test pattern for ChunkBase
Chunks - Adding initMembers pattern to avoid NPE's from within overrides of initReferences
DataVersion added test to catch misconfiguration of enum - and fixed a bug it found
…FileTest to extend it.
… DoubleTagListAsArray and tests
…h values); added tests for same
…ringTagListValues to make getting / setting values of ListTag<StringTag> easier
…s older than MC 1.13
…ore LongArrayTagPackedIntegers.
…ata versions LT JAVA_1_18_21W37A
McaWorld is the start of an effort to abstract away the interactions with individual chunks and mca files. Initial impl supports: - get heightmap value at XZ - get chunk - get region - get/set biome - get/set block
|
I just noticed this PR seems to have grown into a proper fork, great work! I might consider moving over, but I have a couple questions:
I'd love to work together on this! |
* ofBytes * ofShorts * ofInts * ofLongs * ofFloats * ofDoubles * ofStrings
Open
…ndingRectangle, RegionBoundingRectangle
…unkBoundingRectangle, RegionBoundingRectangle
…Tag allowing user to more easily put primitive values.
…ey, Object value)` logic out to Tag static method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love your library! I hope you can incorporate this large refactor which expands the mca API to improve ease of use and is a prerequisite for adding support for the new(ish) POI and ENTITES mca files. Also as I've started looking into the chunk data changes for 1.18... they look to be heading toward somewhat extensive and I'm willing to take on making the changes needed to support 1.18, but I'll be building in that support on top of my fork.
Let me know if you want to chat more, etc. Please perform your own integration testing as well as my changes add some fail-fast check to keep consumers from shooting themselves in the foot.