Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some collector interfaces #15

Merged
merged 4 commits into from
Aug 15, 2023
Merged

add some collector interfaces #15

merged 4 commits into from
Aug 15, 2023

Conversation

saraswatpuneet
Copy link
Contributor

Did few changes

Calling it collectors instead of connectors

  • base class has connect disconnect and poll as async generator type
  • factory is implemented
  • resolve is there

Need to implement local directory collector next

@saraswatpuneet saraswatpuneet self-assigned this Aug 14, 2023
saraswatpuneet
saraswatpuneet commented Aug 14, 2023
View reviewed changes
querent/collectors/collector_base.py
pass

@abstractmethod
async def poll(self) -> AsyncGenerator[CollectorResult, None]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polling will be done async in a generating fashion

@saraswatpuneet saraswatpuneet merged commit 6a5ec5d into main Aug 15, 2023
@saraswatpuneet saraswatpuneet deleted the collector_interfaces branch August 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debanjanamex debanjanamex Awaiting requested review from debanjanamex

Assignees

@saraswatpuneet saraswatpuneet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saraswatpuneet