Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Connector base #14

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Added Connector base #14

merged 1 commit into from
Aug 14, 2023

Conversation

debanjanamex
Copy link
Contributor

made connector_base and connector_factory classes. Followed template of storage and put in comments

@debanjanamex debanjanamex requested a review from Ansh5461 August 13, 2023 20:48
saraswatpuneet
saraswatpuneet reviewed Aug 13, 2023
View reviewed changes
Copy link
Contributor

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Do you intend to add missing pieces in same PR or after this ?
I would say connector_base would have two function for now check_connectivity and stream which is essentially going to start polling files from destinations

@saraswatpuneet saraswatpuneet merged commit 337a703 into main Aug 14, 2023
@Ansh5461 Ansh5461 deleted the connector_base branch November 25, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet left review comments

@Ansh5461 Ansh5461 Awaiting requested review from Ansh5461

Assignees

@saraswatpuneet saraswatpuneet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debanjanamex @saraswatpuneet