Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with other mods with custom inventory sizes #34

Closed
rmobis opened this issue Sep 12, 2021 · 1 comment
Closed

compatibility with other mods with custom inventory sizes #34

rmobis opened this issue Sep 12, 2021 · 1 comment

Comments

@rmobis
Copy link

rmobis commented Sep 12, 2021

I develop (if you can call that developing) a mod for shulker box enchantments (supershulkers), one of which increases the inventory size of said shulker boxes from 27 to 36/45/54. However, Inspecio only displays the first 27.

A similar mod (ShulkerBoxTooltip) has an interface that other mods can implement in order to provide it this kind of information and the implementation, at least from my side, was relatively easy. This is useful not only for shulker boxes but potentially for any modded item.

I'm wondering if there is any similar way to let Inspecio know how many slots a given container has. From snooping around the code on InventoryTooltipComponent.java, I'm inclined to assume there isn't, so I'm also wondering if you'd be willing to accept a PR that works toward it or something else.

@rmobis
Copy link
Author

rmobis commented Sep 5, 2024

CLosing as this seems to have been implemented

@rmobis rmobis closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant