Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image.get_from_stream_async #52

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Conversation

pwmarcz
Copy link
Contributor

@pwmarcz pwmarcz commented Mar 13, 2020

For socket server version of window icon updater.

pwmarcz added a commit to pwmarcz/qubes-gui-daemon that referenced this pull request Mar 14, 2020
As a result, we have a single service running for all the VMs.

Start it using /etc/xdg/autostart to ensure it's running in the
proper graphical session.

Depends on Image.get_from_stream_async, implemented in
QubesOS/qubes-linux-utils#52.
pwmarcz added a commit to pwmarcz/qubes-gui-daemon that referenced this pull request Mar 14, 2020
As a result, we have a single service running for all the VMs.

Start it using /etc/xdg/autostart to ensure it's running in the
proper graphical session.

Depends on Image.get_from_stream_async, implemented in
QubesOS/qubes-linux-utils#52.
pwmarcz added a commit to pwmarcz/qubes-gui-daemon that referenced this pull request Mar 15, 2020
As a result, we have a single service running for all the VMs.
Start it using /etc/xdg/autostart to ensure it's running in the
proper graphical session.

Use (domain, ID) as remote IDs to prevent conflicts between
windows.

Depends on Image.get_from_stream_async, implemented in
QubesOS/qubes-linux-utils#52.
pwmarcz added a commit to pwmarcz/qubes-gui-daemon that referenced this pull request Mar 16, 2020
As a result, we have a single service running for all the VMs.
Start it using /etc/xdg/autostart to ensure it's running in the
proper graphical session.

Use (domain, ID) as remote IDs to prevent conflicts between
windows.

Depends on Image.get_from_stream_async, implemented in
QubesOS/qubes-linux-utils#52.
@marmarek
Copy link
Member

There is one (I hope only one) issue with dropping python2 support here: https://github.com/QubesOS/qubes-app-linux-img-converter:

  • it uses python2 version
  • it is built for both R4.0 and R4.1 from the same branch
  • python3 version of qubesimgconverter module isn't packaged on R4.0 for Debian

@pwmarcz
Copy link
Contributor Author

pwmarcz commented Mar 16, 2020

Okay, how about I:

  1. package Python 3 version for Debian on release4.0 as well (add make install -C imgconverter PYTHON=python3 to the install script)
  2. port qubes-app-linux-img-converter to Python 3?

The alternative is to port qubes-app-linux-img-converter on R4.1 only branch, but then we would have to maintain two branches.

@marmarek
Copy link
Member

1. package Python 3 version for Debian on `release4.0` as well (add `make install -C imgconverter PYTHON=python3` to the install script)

Yes, this one.

pwmarcz added a commit to pwmarcz/qubes-app-linux-img-converter that referenced this pull request Mar 16, 2020
No changes in code necessary, but needs updated qubesimgconverter:

- R4.0: QubesOS/qubes-linux-utils#53
- R4.1: QubesOS/qubes-linux-utils#52
@marmarek marmarek merged commit 0213740 into QubesOS:master Mar 17, 2020
pwmarcz added a commit to pwmarcz/qubes-gui-daemon that referenced this pull request Mar 31, 2020
As a result, we have a single service running for all the VMs.
Start it using /etc/xdg/autostart to ensure it's running in the
proper graphical session.

Use (domain, ID) as remote IDs to prevent conflicts between
windows.

Depends on Image.get_from_stream_async, implemented in
QubesOS/qubes-linux-utils#52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants