Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qubes OS GUI Tools should be tested on 1366x768 displays (or resolutions lower than FHD) #9285

Closed
alimirjamali opened this issue Jun 5, 2024 · 9 comments · Fixed by QubesOS/qubes-desktop-linux-manager#208
Labels
C: tests diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: not applicable E.g., help/support requests, questions, discussions, "not a bug," not enough info, not actionable. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@alimirjamali
Copy link

alimirjamali commented Jun 5, 2024

How to file a helpful issue

Qubes OS release

N/A - All
Screenshots from R4.2.1

Brief summary

According to the statistics (1, 2, 3), over 30% of global desktop users are using monitors with a resolution of 1366x768 or lower than FHD. This figure might be higher in Qubes OS user base as many might be using old generation laptops due to easy Intel ME bypass. Some of the current Qubes OS certified laptops (Nitrokey T430 & X230) are shipped with such displays.

It would be better to test GUI Tools on a low resolution display and assure they work well on such machines.

Steps to reproduce

Open Qubes OS Updater on a display with a resolution of 1366x768. CANCEL & UPDATE buttons are off screen. This might be confusing without background knowledge. Fortunately you could maximize Updater window and get the buttons. Screenshot:
Qubes OS Update GUI

Open Qubes OS policy editor. The 3 buttons are off screen. You can not get them by resizing or maximizing policy editor window. User should use the menu or hot-keys. Screenshot:
Qubes OS Policy Editor

Expected behavior

GUI Tools should appear well on both Half-HD and Full-HD displays.

Actual behavior

GUI Tools are optimized for Full-HD displays.

@alimirjamali alimirjamali added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Jun 5, 2024
@alimirjamali
Copy link
Author

Possibly related:
#9060

@unman
Copy link
Member

unman commented Jun 5, 2024 via email

@unman
Copy link
Member

unman commented Jun 5, 2024 via email

@alimirjamali
Copy link
Author

I've tested this in both KDE and Xfce. I dont know why you should see different.

It would be probable because of the slightly resized XFCE panel bar (36 pixel). I believe most of other settings should be the default XFCE/Adwaita settings.
For better clarification, the tested qubes-desktop-linux-manager version is 4.2.23-1

@marmarek
Copy link
Member

marmarek commented Jun 5, 2024

FWIW, most integration tests (which doesn't mean all the components...) runs with 1024x768 in openQA. And yes, we do notice issues this way from time to time. For example, the policy editor issue is at #9060, found exactly this way.

So, I guess the issue, as worded right now, is done already.

@marmarek marmarek closed this as completed Jun 5, 2024
@marmarek
Copy link
Member

marmarek commented Jun 6, 2024

This is the updater GUI at 1024x768: https://openqa.qubes-os.org/tests/102316#step/qui_widgets_update/10
It fits on the screen there just fine. Maybe it depends on some appearance settings (font size? theme?), or just number of templates?

@alimirjamali
Copy link
Author

alimirjamali commented Jun 7, 2024

I did a sanity check and did qubes-dom0-update --action=reinstall qubes-desktop-linux-manager.

Then I made a quick side-by-side comparison in Krita. Higher number of templates might be the cause of this issue. Or it might be because of the custom labels project I have been working on (and discussing some issues with Marmarta).

It is not a serious issue as it is easy to maximize the Updater and have the CANCEL & UPDATE buttons. Also most users will not have so many templates. Maybe it is better to forget about this issue and focus on more important issues.

updater

@andrewdavidwong andrewdavidwong added R: not applicable E.g., help/support requests, questions, discussions, "not a bug," not enough info, not actionable. C: tests diagnosed Technical diagnosis has been performed (see issue comments). labels Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This issue has been closed as "not applicable." Here are some common examples of cases in which issues are closed as not applicable:

We respect the time and effort you have taken to file this issue, and we understand that this outcome may be unsatisfying. Please accept our sincere apologies and know that we greatly value your participation and membership in the Qubes community.

Regarding help and support requests, please note that this issue tracker (qubes-issues) is not intended to serve as a help desk or tech support center. Instead, we've set up other venues where you can ask for help and support, ask questions, and have discussions. By contrast, the issue tracker is more of a technical tool intended to support our developers in their work. We thank you for your understanding.

If anyone reading this believes that this issue was closed in error or that the resolution of "not applicable" is not accurate, please leave a comment below saying so, and we will review this issue again. For more information, see How issues get closed.

@alimirjamali
Copy link
Author

alimirjamali commented Jun 27, 2024

Maybe it depends on some appearance settings (font size? theme?), or just number of templates?

I know this issue is closed. But I found the reason. It was because of number of long Qube name for two templates. And these two lines:

        width = self.intro_page.vm_list.get_preferred_width().natural_width
        self.main_window.resize(width + 50, int(width * 1.2))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: tests diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: not applicable E.g., help/support requests, questions, discussions, "not a bug," not enough info, not actionable. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants