Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build 2022102511-4.1-fedora-37] openQA test fails in TC_10_VMSalt_fedora-37 #7834

Closed
marmarek opened this issue Oct 26, 2022 · 2 comments · Fixed by QubesOS/qubes-core-admin#493
Closed

[Build 2022102511-4.1-fedora-37] openQA test fails in TC_10_VMSalt_fedora-37 #7834

marmarek opened this issue Oct 26, 2022 · 2 comments · Fixed by QubesOS/qubes-core-admin#493
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: Fedora C: mgmt C: tests diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. r4.1-dom0-stable r4.2-host-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.1 updates

Comments

@marmarek
Copy link
Member

Observation

openQA test in scenario qubesos-4.1-templates-x86_64-system_tests_pvgrub_salt_storage@64bit fails in
TC_10_VMSalt_fedora-37

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/qubes/tests/integ/salt.py", line 312, in test_000_simple_sls
    state_output_json = json.loads(state_output[len(expected_output):])
  File "/usr/lib64/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python3.8/json/decoder.py", line 340, in decode
    raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 18 column 3 (char 557)

This may be either test bug, or salt really doesn't work with Fedora 37 template. Sadly, the test doesn't log enough details to know.

Test suite description

Simple state.sls test.

Reproducible

Fails since (at least) Build 2022102511-4.1-fedora-37 (current job)

Expected result

Last good: 20220527-4.1-fedora-36 (or more recent)

Further details

Always latest result in this scenario: latest

Blocks #7807
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: mgmt C: Fedora labels Oct 26, 2022
@marmarek marmarek added this to the Release 4.1 updates milestone Oct 26, 2022
@andrewdavidwong andrewdavidwong added C: tests needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Oct 26, 2022
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Oct 31, 2022
@marmarek
tests/salt: improve error logging on JSON decoding error
864acef 
QubesOS/qubes-issues#7834
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Oct 31, 2022
@marmarek
tests/salt: workaround warning reported by Salt
3e6b30e 
Workaround for saltstack/salt#60476
It prints warning to stdout(?!). The issue is fixed upstream already,
but the fix isn't packaged yet. At this time, it affects Fedora 37 only.

Fixes QubesOS/qubes-issues#7834
@marmarek marmarek mentioned this issue Oct 31, 2022
Merged
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 15, 2022
@marmarek
tests/salt: improve error logging on JSON decoding error
15edff4 
QubesOS/qubes-issues#7834

(cherry picked from commit 864acef)
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 15, 2022
@marmarek
tests/salt: workaround warning reported by Salt
4562943 
Workaround for saltstack/salt#60476
It prints warning to stdout(?!). The issue is fixed upstream already,
but the fix isn't packaged yet. At this time, it affects Fedora 37 only.

Fixes QubesOS/qubes-issues#7834

(cherry picked from commit d17b669)
@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin (including package qubes-core-dom0-4.1.29-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Nov 15, 2022
Closed
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Nov 15, 2022
@qubesos-bot qubesos-bot mentioned this issue Nov 16, 2022
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin (including package qubes-core-dom0-4.1.29-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: Fedora C: mgmt C: tests diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. r4.1-dom0-stable r4.2-host-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.1 updates
Development

Successfully merging a pull request may close this issue.

Fixes to salt tests marmarek/qubes-core-admin
3 participants
@marmarek @andrewdavidwong @qubesos-bot