Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's impossible to set firewall policy and rules atomically #2869

Closed
marmarek opened this issue Jun 26, 2017 · 1 comment
Closed

It's impossible to set firewall policy and rules atomically #2869

marmarek opened this issue Jun 26, 2017 · 1 comment
Assignees
@marmarek
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. r4.0-dom0-cur-test T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Milestone
Release 4.0

Comments

@marmarek
Copy link
Member

Sometimes it's useful to update firewall rules while VM is running. In this case, it's important to atomically set the firewall - especially when VM have some traffic filtered, it should not have access to those targets also during loading new firewall.
Having separate policy (default action) and actual rules makes it hard.
Safer alternative: always have policy "drop" and optionally put "always allow" rule at the end.
@marmarek marmarek added C: core T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. P: major Priority: major. Between "default" and "critical" in severity. labels Jun 26, 2017
@marmarek marmarek added this to the Release 4.0 milestone Jun 26, 2017
@marmarek marmarek self-assigned this Jun 26, 2017
marmarek added a commit to QubesOS/qubes-doc that referenced this issue Jun 26, 2017
@marmarek
admin-api: remove separate methods for firewall policy
9cd7cee 
QubesOS/qubes-issues#2869
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jun 26, 2017
@marmarek
api/admin: firewall-related methods
0200fda 
In the end firewall is implemented as .Get and .Set rules, with policy
statically set to 'drop'. This way allow atomic firewall updates.

Since we already have appropriate firewall format handling in
qubes.firewall module - reuse it from there, but adjust the code to be
prepared for potentially malicious input. And also mark such variables
with untrusted_ prefix.

There is also third method: .Reload - which cause firewall reload
without making any change.

QubesOS/qubes-issues#2622
Fixes QubesOS/qubes-issues#2869
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Jun 26, 2017
@marmarek
firewall: drop GetPolicy/SetPolicy calls
7294a43 
Firewall policy is now hardcoded to 'drop'. Keep the property, so anyone
trying to assign it will get an exception

QubesOS/qubes-issues#2869
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Jun 26, 2017
@marmarek
tools: remove policy handling from qvm-firewall tool
10cc38e 
Follow the API removal

QubesOS/qubes-issues#2869
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-dom0-4.0.1-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Jul 4, 2017
Closed
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Jul 5, 2017
@marmarek
firewall: drop GetPolicy/SetPolicy calls
942e122 
Firewall policy is now hardcoded to 'drop'. Keep the property, so anyone
trying to assign it will get an exception

QubesOS/qubes-issues#2869
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Jul 5, 2017
@marmarek
tools: remove policy handling from qvm-firewall tool
627aebf 
Follow the API removal

QubesOS/qubes-issues#2869
@qubesos-bot qubesos-bot mentioned this issue Jul 5, 2017
Closed
@anadahz anadahz mentioned this issue Mar 9, 2019
Merged
This was referenced Jul 30, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarek marmarek

Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. r4.0-dom0-cur-test T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
Release 4.0
Development

No branches or pull requests
2 participants
@marmarek @qubesos-bot