Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop automatic generator of salt-minion configuration #2048

Closed
marmarek opened this issue Jun 5, 2016 · 0 comments
Closed

Drop automatic generator of salt-minion configuration #2048

marmarek opened this issue Jun 5, 2016 · 0 comments
Labels
C: mgmt P: major Priority: major. Between "default" and "critical" in severity. T: task Type: task. An action item that is neither a bug nor an enhancement.
Milestone
Release 3.2

Comments

@marmarek
Copy link
Member

marmarek commented Jun 5, 2016

The only real reason for having it in place, is to generate file_roots setting to include directories of enabled formulas. But since salt 2015.8 (or our backport of related feature), just placing a file in /etc/salt/minion.d/ to append appropriate directory. For now do it at package level (so include directory even if related formula isn't enabled), but if needed in the future, it can be easily added to top.enable function (or similar mechanism).

This greatly reduce complexity of salt setup.
@marmarek marmarek added P: major Priority: major. Between "default" and "critical" in severity. T: task Type: task. An action item that is neither a bug nor an enhancement. C: mgmt labels Jun 5, 2016
@marmarek marmarek added this to the Release 3.2 milestone Jun 5, 2016
marmarek added a commit to marmarek/qubes-mgmt-salt-base that referenced this issue Jun 7, 2016
@marmarek
Drop 'state.sls config' calls
45df2fb 
It isn't used anymore

QubesOS/qubes-issues#2048
marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-qvm that referenced this issue Jun 7, 2016
@marmarek
Drop 'state.sls config' call
a8b8cb3 
It isn't used anymore.

QubesOS/qubes-issues#2048
marmarek added a commit to marmarek/qubes-mgmt-salt that referenced this issue Jun 7, 2016
@marmarek
sync default minion.d/f_defaults.conf with final generated one
220e4c7 
Since it will not be regenerated in a moment, have the right file here.

QubesOS/qubes-issues#2048
marmarek added a commit to marmarek/qubes-mgmt-salt that referenced this issue Jun 7, 2016
@marmarek
Drop 'state.sls config' call
60c5c4b 
It isn't used anymore

QubesOS/qubes-issues#2048
marmarek added a commit to marmarek/qubes-mgmt-salt that referenced this issue Jun 7, 2016
@marmarek
qubesctl: apply salt backports
f183c56 
Even in fc23-based dom0 it is needed to apply them (see
QubesOS/qubes-issues#2048), to correctly render top file.

Otherwise qubesctl doesn't correctly detect which VMs have any
configuration to apply.

QubesOS/qubes-issues#1541
marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-update that referenced this issue Jun 15, 2016
@marmarek
Drop 'state.sls config' call
6b9df44 
It isn't used anymore

QubesOS/qubes-issues#2048
@qubesos-bot qubesos-bot mentioned this issue May 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: mgmt P: major Priority: major. Between "default" and "critical" in severity. T: task Type: task. An action item that is neither a bug nor an enhancement.
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@marmarek