Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qrexec service should be able to return stderr in addition to stdout #1808

Closed
marmarek opened this issue Mar 5, 2016 · 0 comments
Closed

Qrexec service should be able to return stderr in addition to stdout #1808

marmarek opened this issue Mar 5, 2016 · 0 comments
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Milestone
Release 3.2

Comments

@marmarek
Copy link
Member

marmarek commented Mar 5, 2016

In case of some services it makes much sense for caller to receive also
stderr in addition to stdout. For example:

  • qubes.VMShell (stderr required for salt-ssh over qrexec)
  • qubes.OpenInVM - especially when called to DispVM - otherwise
    diagnosing errors can be hard (and logs are lost after destruction of DispVM)

Generally all sort of error reporting (the purpose of stderr). It would ease debugging - instead of message "error occurred, check here and there for more details", it could be "error occurred: the reason".
@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. labels Mar 5, 2016
@marmarek marmarek added this to the Release 3.2 milestone Mar 5, 2016
marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue Mar 5, 2016
@marmarek
qrexec: write service stderr to both syslog and caller
b267e5c 
In case of some services it makes much sense for caller to receive also
stderr in addition to stdout. For example:
 - qubes.VMShell (stderr required for salt-ssh over qrexec)
 - qubes.OpenInVM - especially when called to DispVM - otherwise
 diagnosing errors can be hard

And generally all sort of error reporting (the purpose of stderr). It
would ease debugging - instead of message "error occurred, check here and
there for more details", it could be "error occurred: the reason".

Fixes QubesOS/qubes-issues#1808
This was referenced Mar 5, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@marmarek