Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulse: starting/stopping improvements #43

Merged
merged 2 commits into from
Apr 9, 2020
Merged

pulse: starting/stopping improvements #43

merged 2 commits into from
Apr 9, 2020

Conversation

marmarek
Copy link
Member

@marmarek marmarek commented Apr 6, 2020 •
edited
Loading

  1. Terminate when the target domain is killed
  2. Create a pidfile (/var/run/qubes/pacat.) to prevent multiple instances.

The second one will only be effective with #35, as otherwise pacat-simple-vchan
is started as root (so the pidfile is unreadable for the normal user), but also
is killed with SIGTERM and does not cleanup the pid file.

Fixes QubesOS/qubes-issues#5760

@marmarek
pulse: periodically check if vchan connection is alive
ad3b39c 
If the remote domain is killed, vchan may not get the notification. To
avoid hanging process in such a case, periodically check if vchan
connection is open (as other vchan applications do).

This partially reverts d0fcc6c.

Fixes QubesOS/qubes-issues#5760
@marmarek
pulse: create pidfile
dff304a 
Create a pidfile and take a lock on it. Prevent starting multiple
instances for the same VM.

Fixes QubesOS/qubes-issues#5760
@qubesos-bot
Copy link

qubesos-bot commented Apr 6, 2020 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/7491#dependencies

Failed tests

New failures

Compared to: https://openqa.qubes-os.org/tests/6362#dependencies

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/6362#dependencies

@marmarek marmarek mentioned this pull request Apr 7, 2020
Merged
@marmarek marmarek merged commit f6c6425 into QubesOS:master Apr 9, 2020
@marmarek marmarek deleted the pacat-start-stop branch August 30, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openqa-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulseaudio: pacat-simple-vchan startup and termination
2 participants
@marmarek @qubesos-bot