Skip to content

change sphinx output format to dirhtml#1530

Open
saces wants to merge 1 commit intoQubesOS:mainfrom
saces:dirhtml
Open

change sphinx output format to dirhtml#1530
saces wants to merge 1 commit intoQubesOS:mainfrom
saces:dirhtml

Conversation

@saces
Copy link
Contributor

@saces saces commented Sep 12, 2025

this produces prettier urls without '.html' at the end

this produces prettier urls without '.html' at the end
@marmarek
Copy link
Member

It may be a bit late for that...

While URLs may be nicer, I think this would break links that are already out there, no? Especially the whole QubesOS/qubesos.github.io#243

Any rename/link change needs to come with matching redirect from the old one.

@maiska
Copy link
Contributor

maiska commented Sep 12, 2025

I wanted to test this out, @parulin also made the suggestion, I had some weird stuff locally I think with auto-build and did not have the time to look into this, and low prio, but coming I can and also prepare a redirects PR to qubesos.github.io.
It will take time, still low prio imho :)

@parulin
Copy link
Contributor

parulin commented Sep 12, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

@maiska
Copy link
Contributor

maiska commented Sep 12, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

no, i don't think so. there should not be anchors in the redirects, and if it is sufficiently tested and run by the link checker in rst itself we should be good. i do not see a lot of overhead here, but it will be approached at a slow pace and testing is needed

@parulin
Copy link
Contributor

parulin commented Sep 13, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

no, i don't think so. there should not be anchors in the redirects, and if it is sufficiently tested and run by the link checker in rst itself we should be good. i do not see a lot of overhead here, but it will be approached at a slow pace and testing is needed

Sorry, I wasn't clear. I had the forum in mind, or any external source: any link containing an anchor is lost.

I.e.: https://www.qubes-os.org/doc/glossary/#qube will redirect to https://doc.qubes-os.org/en/latest/user/reference/glossary.html, not https://doc.qubes-os.org/en/latest/user/reference/glossary.html#qube

So, moving again from https://doc.qubes-os.org/en/latest/user/reference/glossary.html to https://doc.qubes-os.org/en/latest/user/reference/glossary/ will have the same effect.

@maiska
Copy link
Contributor

maiska commented Sep 13, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

no, i don't think so. there should not be anchors in the redirects, and if it is sufficiently tested and run by the link checker in rst itself we should be good. i do not see a lot of overhead here, but it will be approached at a slow pace and testing is needed

Sorry, I wasn't clear. I had the forum in mind, or any external source: any link containing an anchor is lost.

I.e.: https://www.qubes-os.org/doc/glossary/#qube will redirect to https://doc.qubes-os.org/en/latest/user/reference/glossary.html, not https://doc.qubes-os.org/en/latest/user/reference/glossary.html#qube

So, moving again from https://doc.qubes-os.org/en/latest/user/reference/glossary.html to https://doc.qubes-os.org/en/latest/user/reference/glossary/ will have the same effect.

There is a possible solution to this: https://github.com/sphinx-doc/sphinxext-rediraffe

Let this be tackled in due time though. I would not like a discussion that needs time, and i cannot take the time to research and properly involve

@parulin
Copy link
Contributor

parulin commented Sep 14, 2025

So, moving again from https://doc.qubes-os.org/en/latest/user/reference/glossary.html to https://doc.qubes-os.org/en/latest/user/reference/glossary/ will have the same effect.

Never mind, I suppose that we will move from /latest/ to /stable/ URLs in the future so please ignore my previous comment :)

@marmarek
Copy link
Member

Look what I found in RTD settings:
image

@rapenne-s
Copy link
Contributor

Look what I found in RTD settings: image

Did you enable it? Do we want to make a change about the .html at the end of URLs?

@marmarek
Copy link
Member

Did you enable it?

No. Should I?

Note that redirects drop anchor part of the URL, so (old) links to specific sections won't work.

@parulin
Copy link
Contributor

parulin commented Dec 11, 2025

@maiska had some tests to run before that.

I still think that it would be better to change the builder and resolve QubesOS/qubes-issues#10251 at the same time, to limit the anchor problem.

@unman
Copy link
Member

unman commented Feb 11, 2026

It will be a mistake to lose the ability to link within pages. It is widely used in the docs and for external reference. We should not do this.

@parulin
Copy link
Contributor

parulin commented Feb 12, 2026

It will be automatically managed by Sphinx for internal links. The only issue concerns external links to the docs. As I said, if resolving QubesOS/qubes-issues#10251 changes the default URLs, merging #1530 won't harm.

@unman
Copy link
Member

unman commented Feb 13, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants