-
-
Notifications
You must be signed in to change notification settings - Fork 511
Prepare for translation #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for translation #1123
Conversation
This is problematic for Transifex API and also ease building language-specific links.
|
testdeploy |
7c9fb24 to
0d50970
Compare
|
testdeploy |
- mark all code blocks with ``` - unify empty lines between sections - adjust list syntax (no space before dash) - adjust headers to use Atx-style syntax - remove trailing spaces
- sort keys - remove permalink from redirects
In fact, right now those pages content is duplicated - once included here and once inserted by the doc-content (or hcl) layout.
Those are fields used by the language switcher to correlate pages across different languages, even if they have different names/paths/titles. They are generated with the prepare_for_translation.py script.
0d50970 to
820af56
Compare
|
I went through a diff of resulting HTML files (but stripping actual HTML tags for the diff purpose - using The command I used to diff is: where the old version (built from the master branch) is in |
|
testdeploy |
No, it should be one or the other, not both (except when the code block appears inside of a list, in which case both the fence and the code should be indented to the same level). Doing both results in a code block where each line is indented, which we don't want. This page contains several examples: https://wwwpreview.qubes-os.org/doc/automated-tests/ Can you remove the excess indentation in cases where ``` fences have been added? |
|
Never mind, found it from the button below. |
|
This PR causes some, but not all, of the items in the ToC to be indented by one: https://wwwpreview.qubes-os.org/doc/ I can see why, but I don't think the indentation is desired on this page, because these are all actually supposed to be at the same level. It's just that some sections are organized with subheadings, while others aren't. However, it's not that big of a deal, so if you prefer it this way, it's fine. |
|
Do I have to worry about things like |
I don't think that matter that much. In any case, I'd like to have this page automatically generated anyway, so the current state is rather temporary.
You don't need to worry, it will be handled automatically. One thing that is necessary is to remove it if you ever make a copy of a page (there must be no duplicates). |
Ah yes, it is. In the interest of avoiding further merge conflicts and fixing QubesOS/qubes-issues#6489, I'm going to merge this now (keeping the new changes from #1125). However, I still think the code block issue should be fixed. |
This is similar PR to QubesOS/qubesos.github.io#153
The intention is to do all the ground work, without actually enabling the translations yet. The changes are:
This all is work done by @maiska (marmarek#3), with git commits cleaned up. Thanks!