Support wait-for-session in qrexec-client #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwmarcz
force-pushed
the
wait-for-session
branch
from
958b752
to
4993389
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 73.70% 74.14% +0.44%
==========================================
Files 41 41
Lines 6221 6300 +79
Branches 459 474 +15
==========================================
+ Hits 4585 4671 +86
+ Misses 1394 1375 -19
- Partials 242 254 +12
Continue to review full report at Codecov.
|
pwmarcz
force-pushed
the
wait-for-session
branch
from
4993389
to
c4b1cd4
Compare
marmarek
requested changes
Mar 27, 2020
libqrexec/exec.c
Outdated
| goto err; | ||
| } | ||
| } else { | ||
| cmd->service_name = strdup(cmd->service_descriptor); |
There was a problem hiding this comment.
Suggested change
| cmd->service_name = strdup(cmd->service_descriptor); | |
| cmd->service_name = strndup(cmd->service_descriptor, end - start); |
?
There was a problem hiding this comment.
I'll do strndup(start, end - start), same as for cmd->service_descriptor.
Clean up qrexec_parsed_command to make the code simpler: allocate more strings and store NUL-terminated parts.
Add qubes.WaitForSession to dom0, to wait until qubes-guid becomes available for a given domain. This will be useful for RPC calls that require GUI (currently qubes.WindowIconUpdater).
pwmarcz
force-pushed
the
wait-for-session
branch
from
c4b1cd4
to
c764187
Compare
pwmarcz
force-pushed
the
wait-for-session
branch
from
c764187
to
7f6d27b
Compare
marmarek
approved these changes
Mar 28, 2020
pwmarcz
added a commit
to pwmarcz/qubes-gui-daemon
that referenced
this pull request
Mar 31, 2020
Added to dom0 in QubesOS/qubes-core-qrexec#41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.